-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Program Areas page so projects are dynamically rendered #3593
Updated Program Areas page so projects are dynamically rendered #3593
Conversation
Hide project data to show only mini cards and information.
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: EOD 2022-09-30 |
Hey, @jdingeman Thank you so much for putting in all the hard work. It looks great. I can see that the projects are being rendered which were not previously. Which is great I wonder if we are missing cards for a reason for a few projects that are being rendered on the Hackforla website but not here
|
Hey, @arpitapandya. It appears this is due to some inconsistencies between the program area yml files and the projects md files.
I don't mind correcting the latter two since they are minor changes due to typos, if that is okay. |
Ok, we can consider them to write Good: Second Issues for new devs. No problem, Looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes are correct! Great work! @jdingeman
Fixes #2485
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
** Note that this now adds projects that were not previously rendered.
** Also corrected minor typo in guides-team.md that prevented card from being rendered.