Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change content to content-type and remove type: icon #3559

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

palomasoltys
Copy link
Member

Fixes #2827

What changes did you make and why did you make them ?

  • Changed "content: icon" to "content-type: image";
  • Removed "type: icon"

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b palomasoltys-edit-content-field-2827 gh-pages
git pull https://github.com/palomasoltys/website.git edit-content-field-2827

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review labels Sep 16, 2022
@lilyarj lilyarj self-requested a review September 18, 2022 15:59
Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

Copy link
Member

@jdingeman jdingeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from the correct branch palomasoltys:edit-content-field-2827 and goes to the correct branch hackforla:gh-pages. It has a linked issue, the linked issue is addressed by changing content to content-type and icon to image on line four and deleting line 11. The code is clean and there's only one commit. Good Job!

@blulady blulady merged commit 49be8ab into hackforla:gh-pages Sep 18, 2022
@palomasoltys palomasoltys deleted the edit-content-field-2827 branch September 20, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from folder.yml credits file
4 participants