-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change content to content-type and remove type: icon #3559
Change content to content-type and remove type: icon #3559
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from the correct branch palomasoltys:edit-content-field-2827 and goes to the correct branch hackforla:gh-pages. It has a linked issue, the linked issue is addressed by changing content to content-type and icon to image on line four and deleting line 11. The code is clean and there's only one commit. Good Job!
Fixes #2827
What changes did you make and why did you make them ?