Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies action 2065 #3414

Conversation

BeckettOBrien
Copy link
Member

Fixes #2065

What changes did you make and why did you make them ?

  • Created .github/workflows/update-dependencies-issue.yml
  • Created github-actions/update-dependencies-issue/update-issue-template.md

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Created a new GitHub Actions workflow. No visual changes to the site.

Notes

There are a few things that might need to change before this PR can actually be merged:

  • Right now the action is set to trigger once a week, but that might be too often for creating a fairly large issue
  • I'm still pretty new to writing issues so my draft of the template probably needs editing
  • We need to decide what column of the project board the issue should go in, and someone needs to create a GitHub secret with its ID

@github-actions github-actions bot added automation for manulal github board maintenance actions that are going to be automated Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours Complexity: Medium Status: Help Wanted Internal assistance is required to make progress labels Jul 21, 2022
@kathrynsilvaconway
Copy link
Member

ETA: End of day 7/27
Availability: 3 Hours

@blulady
Copy link
Member

blulady commented Jul 24, 2022

ETA: 7.24.22
Availability: 7.25.22

@blulady
Copy link
Member

blulady commented Jul 24, 2022

ETA: 22-7-24
Availability: 22-7-24, 22-7-25

@ExperimentsInHonesty
Copy link
Member

@blulady Checking in on your on this PR. You indicated you were avail on 24 & 25 and the eta was 24. I don't see a review from you. Do you need to be unassigned as a reviewer? If yes, please reach out to @Zak234 and ask him to do a review

@ExperimentsInHonesty
Copy link
Member

@blulady @kathrynsilvaconway FYI The intern who opened this PR- last day is Friday, so we need to respond to him in a timely way, so that he can fix anything that comes up before he goes.

@blulady
Copy link
Member

blulady commented Jul 27, 2022

@blulady Checking in on your on this PR. You indicated you were avail on 24 & 25 and the eta was 24. I don't see a review from you. Do you need to be unassigned as a reviewer? If yes, please reach out to @Zak234 and ask him to do a review

Hey Bonnie, so after you bailed on the Monday meeting we started talking about how I actually can't test this PR because when I wiped my repo and re-forked, I no longer had access to classic projects. I expected this PR to be closed the way we closed the other PR involving {{ secrets.PRIORITIZED_BACKLOG_COLUMN_ID }} and there is still yet another PR with this issue. Which is why I didn't unassign myself as a reviewer but I am happy to do it now. This issue is experiencing a similar problem. #3426

@blulady blulady removed their request for review July 27, 2022 22:33
@BeckettOBrien
Copy link
Member Author

If it's too much of a hassle I can just put the column ID directly in the action and not use GitHub Secrets (I think the column id is publicly available information anyway). I just used a secret because I saw that other actions have used secrets for column ids in the past. Also, would we rather put the issue in the new issue approval or the prioritized backlog? I can think of benefits and tradeoffs for both, so just let me know which one you think would work best and I'll add the ID to the action.

@ExperimentsInHonesty
Copy link
Member

@BeckettOBrien please have it not use GitHub secrets if that information does not need to be secret.

@ExperimentsInHonesty
Copy link
Member

@blulady
I'll send Beckett to Office hours tonight to see if this can get resolved. I don't think I really understand the problem that these two issues are having.

@hackforla/website-merge What do you want Beckett to do if he can't finish this issue before internship is over. Should we have someone take over the PR?

@BeckettOBrien BeckettOBrien force-pushed the update-dependencies-action-2065 branch from c6c0378 to f604e0e Compare July 28, 2022 18:10
@BeckettOBrien
Copy link
Member Author

That should be the only change that prevented the action from being deployed, and everything else (schedule, the contents of the issue posted, etc.) can be changed later and (hopefully) without needing my help.

  • To change the issue contents, including the name and labels, edit `github-actions/update-dependencies-issue/update-issue-template.md
  • To change the schedule, change line 6 of .github/workflows/update-dependencies-issue.yml
  • To change the column of the project board the issue gets posted in, change line 23 of .github/workflows/update-dependencies-issue.yml (if you click "Copy Link" on a project board column, the ID will be after the dash in the link, ex: https://github.com/hackforla/website/projects/7#column-7198257 is 7198257

@BeckettOBrien BeckettOBrien marked this pull request as ready for review July 28, 2022 18:18
@BeckettOBrien BeckettOBrien removed the Status: Help Wanted Internal assistance is required to make progress label Aug 15, 2022
@Zak234 Zak234 self-requested a review August 28, 2022 17:48
@blulady
Copy link
Member

blulady commented Oct 4, 2022

#3598 Please see this issue for details as to why we are closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation for manulal github board maintenance actions that are going to be automated Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

GitHub Actions: Create issue at a timed interval to check for updates to GHA version
4 participants