-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update profile food oasis 3232 #3318
Update profile food oasis 3232 #3318
Conversation
For some reason it is saying I submitted two commits, when I only submitted the second one. How do I change this? |
Hi @lilyarj Thank you for making note of the issues you encountered while working through this issue. I am checking in with @raswani2023 as it looks like she is the one responsible for the other commit. I will probably have you rebase this PR (and will write out some directions for that) but would like you to hold on for a bit while I figure out what happened on their side. Thanks for your patience. |
Okay cool thank you so much. Also idk if this is useful information but I did review Riya's PR request right before I started working on this issue. |
Hey @lilyarj after checking on the issue it looks like you were a reviewer on the issue that the extra file/commit is connected to. Please make sure that when you are adding files to commit that you do so explicitly. Using For this issue I'm going to ask you to follow this guide to remove the extra file. Let me know if you have any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ETA: End of day, as soon as requested changes are made. @lilyarj Don't forget to request a re-review from me as soon as you finish your changes. |
Hi, @kathrynsilvaconway @Sparky-code I followed the steps in the guide, but I'm unsure what to do after that. Do I re submit another pull request, or is it supposed to auto update? lilyarjomand@Lilys-MacBook-Pro website % git checkout a2883aa -- _data/internal/credits/code.yml` |
hI @lilyarj , I am not completely sure if further action is needed or not. I am going to discuss it during office hours this evening. |
The commit errors in this PR have prompted us to begin work on a new guide for deleting/preventing these issues. For the immediate issue, we will close this PR and have @lilyarj open a new one. |
Fixes #3232
What changes did you make and why did you make them ?
Name: John
GitHub handle: @entrotech
Role: Architect and Technology Lead
Slack ID: UFLDX9V19
Name: Bryan Wu
GitHub handle: @fancyham
Role: Design Lead
Slack ID: U01PG6RD0T1
Name: Jieun Ryu
GitHub handle: @ryu-jieun
Role: UX Researcher
Slack ID: U02LL2DF4HL
Name: Gigi Patel
GitHub handle: @LIlinit
Role: UX Researcher
Slack ID: U02KZ8WSHHV
Name: Virginia Wu
GitHub handle: VirginiaWu11
Role: Full Stack Engineer
Slack ID: U02G7SBKSV7
Name: Seiko Igi
GitHub handle: @sei1122
Role: Product Designer
Slack ID: U02U55MQEQ7
Name: Hannah Zulueta
GitHub handle: hanapotski
Role: Full Stack Engineer
Slack ID: U9SCMTNK0 ( I actually used a different slack id, one that I got off slack for Hannah Zulueta because this one did not connect to an account) - This was the one I used (U01G7AH18J3)
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied