Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tools section to current project cards #3020

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Added tools section to current project cards #3020

merged 2 commits into from
Apr 5, 2022

Conversation

Jaretzbalba
Copy link
Member

Fixes #2764

What changes did you make and why did you make them ?

-Added tools section to current-projects.js file in order to show the tools used on the project page itself.
-Now the individual project information pages and their respective cards will match.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

project_page_tools_BEFORE

Visuals after changes are applied

project_page_tools_AFTER

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Jaretzbalba-update-project-card-tools-2764 gh-pages
git pull https://github.com/Jaretzbalba/website.git update-project-card-tools-2764

@github-actions github-actions bot added P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Complexity: Medium labels Mar 28, 2022
@1anya1 1anya1 self-requested a review March 28, 2022 22:06
@1anya1
Copy link
Member

1anya1 commented Mar 28, 2022

Availability: 3hrs,
ETA: Tuesday, March 29th

@answebdev
Copy link
Member

Review ETA: 3/31/2022 (end of day)
Availability: 3 hours

@scarter31191
Copy link
Member

Review ETA: 3/30/2022
Availability: 3 hours

answebdev
answebdev previously approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@answebdev answebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jaretzbalba Thank you for submitting your PR. For this issue, the Tools field needed to be added to the project cards on the Projects page. I was able to see the changes locally, as well as see the Tools field, along with the listed tools, on the projects that do have tools. Also, the Tools field does not show up on project cards that do not have tools listed (e.g., Guides Team), as per the instructions in the issue. Great job!

Also, I was wondering @SAUMILDHANKAR or @JessicaLucindaCheng , although everything was followed and completed according to the issue, wouldn't the tools field look better if it were capitalized, since all of the other fields on the cards are capitalized (e.g., Links, Partner, Languages, etc.)? That came to mind as I was checking in the browser and thought I'd mention it.

@JessicaLucindaCheng
Copy link
Member

@Jaretzbalba As @answebdev mentioned, the tools fields on the card should be capitalized so it looks similar to the other fields on the cards, which are all capitalized. So, tools: for each of the cards should become Tools:

image

@Jaretzbalba
Copy link
Member Author

@answebdev @JessicaLucindaCheng Thank you for the input and I've now updated the code to have everything match. Please let me know if there are any further changes that should be implemented.

answebdev
answebdev approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@answebdev answebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jaretzbalba Thank you for updating the code to have everything match. I was able to see the updated code, and was also able to see the update in the browser. Good job!

@kathrynsilvaconway kathrynsilvaconway self-requested a review April 3, 2022 02:48
@kathrynsilvaconway
Copy link
Member

Review ETA: 4/05/2022 (end of day)
Availability: 3 hours

kathrynsilvaconway
kathrynsilvaconway approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@kathrynsilvaconway kathrynsilvaconway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jaretzbalba, really nice job on this issue. I can see that the Tools section now appears on all of the project cards that have tools listed. The word "tools" has also been capitalized. I went through the .mds for all the projects, and I don't see any discrepancies. Looks good on all the mobile views as well. Overall, very good work.

@answebdev answebdev merged commit 5af1a6c into hackforla:gh-pages Apr 5, 2022
JessicaLucindaCheng added a commit to JessicaLucindaCheng/website that referenced this pull request Apr 14, 2022
@JessicaLucindaCheng @BrianCodes33
@HackforLABot @Providence-o @anthonysim @ExperimentsInHonesty @R-Tomas-Gonzalez @frankstepanski @lindseyindev @JasonY188 @SAUMILDHANKAR @Carlos-A-P @KazushiR @luke-karis @Sparky-code @Gorck1416 @answebdev @tamara-snyder @1anya1 @A-BMT02 @harshitasao @jnmrles @usaboo @blulady @Jaretzbalba @maybleMyers @scarter31191 @poorvi4 @riddle015 @macho-catt @RyanCahela @kathrynsilvaconway
Updating homepage branch (#11)
ed85ac2 
* Update how the overview link opens for Engage (hackforla#2734)

Engage's overview link was updated so it opens the Engage-Product-One-Sheet.pdf in a new tab.

* Update meeting data

* Update contributor and language data

* Update issue templates

We updated the Project profile card template to include VRMS instructions for meeting time change

* Update tech dropdown 2397 (hackforla#2672)

* added css grid to technologies dropdown

* added media queries for min-width 768 & min-width 1024

* removed redundant css from min-width 1024

* updated comments

* removed comment out css

* added variables $bp-tablet-up} & $bp-desktop-up

* added scrollbar

* updated height for desktop

* changes to account for Surface Duo Screen 540px

* added layout for ipad air with comments

* changed $bp-ipadair-up to $bp-ipadair-up

* Removed comments unrelated to pr 2672 from variables/_layout.scss (hackforla#2724)

* Update meeting data

* Update contributor and language data

* Update communities-of-practice-information-updates.yml

added a feature label to the template

* Tooltip bug fix (hackforla#2713)

* added overflow visible to project-card-wins-card style in winspage sccss.

* Updated Git Wiki link in Contributing.md (hackforla#2741)

* Update link in Contributing.md (hackforla#2742)

* Update meeting data

* Update contributor and language data

* Apply Title heading class to Events page hackforla#2081 (hackforla#2645)

* added Title class to specified  event headings

* added title-meetup text-color class to match figma

* lowercased title classes

* utilizing color-black and updated h5 to h4

* added text color property to day-header-1

* Update meeting data

* Update contributor and language data

* Revert "Removed comments unrelated to pr 2672 from variables/_layout.scss (hackforla#2724)"

This reverts commit 3bc8d50.

* Revert "Update tech dropdown 2397 (hackforla#2672)"

This reverts commit 9b97a8b.

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* change b tag to strong tag (hackforla#2762)

Co-authored-by: Jason Yee <[email protected]>

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Updated pre-work developer template

Added a checkbox for reading 2.6 What to do when you need to stop mid issue. (Section 2.6 is in the Contributing.md).

* Added the template to edit content field and remove type field in a Credits file

* Clarified wording in Credits file template: Edit content field and remove type field

* removed about-us file (hackforla#2769)

* Update meeting data

* Update contributor and language data

* Update Credits file template: Edit content field and remove type field

Included this line in the template "This issue is tracked in the epic hackforla#2775."

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Made changes to spare.md issue 2437 (hackforla#2778)

* Update contributor and language data

* Update link 100automations 2233 (hackforla#2785)

* change url in md file

* update url in md file

* Add youth justice pdf and link it to overview (hackforla#2780)

* access - update to strong (hackforla#2786)

* Apply heading class to Program Areas Page (hackforla#2779)

* applied heading class to Program Areas Page

* changed h3 tag to h2 tag

* Update meeting data

* Update contributor and language data

* pages/getting-started-with-video.html was removed from the fileand the error 404 page appeared when checking in localhost:4000 (hackforla#2788)

* Updated Credits file template: Edit content field and remove type field

* Update Credits file template: Edit content field and remove type field

Clarified that the permalinks should be for the content and type fields

* Update Credits file template: Edit content field and remove type field

Clarified a sentence

* Change bold to strong in step 5 (hackforla#2787)

* Change bold to strong in step 5

* fixed indentation and spacing

* Update meeting data

* Update contributor and language data

* Updated Credits file template: Edit content field and remove type field

Clarified the title and a sentence in the template

* Updated Alt Text Audit - Dev

Fixed typo

* Updated Credits file template: Edit content field and remove type field

Added an example of a permalink as a comment on the bottom of the template.

* Updated Alt Text Audit - Dev

Add the 1pt size label to the template

* Update meeting data

* Update contributor and language data

* Update issue templates

updated the UX pre template

* Update meeting data

* Update contributor and language data

* replaced hard coded blue colors with variables, removed unused blues (hackforla#2767)

* applied title3 class to h2 tags (hackforla#2803)

* add program-area text to Resources section (hackforla#2819)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Refactor Buttons on Sitemap and Events Pages - hackforla#2159 (hackforla#2789)

* Refactor buttons on line 43 of website/pages/sitemap.html, line 65 of website/pages/sitemap.html, and line 19 of website/_includes/events-page/left-col-content.html

* Update made to change bold to strong for line 91 (hackforla#2841)

* Update meeting data

* Update contributor and language data

* remove-non-existent-classes-2721 (hackforla#2879)

* Update meeting data

* Update contributor and language data

* edited act.yml file (hackforla#2883)

* clarified contributing section in README.md (hackforla#2881)

* Update meeting data

* Update contributor and language data

* update program-area text (hackforla#2885)

* made changes to CONTRIBUTING.md for easier understanding (hackforla#2893)

* Added weekly meeting requirements

* Update meeting data

* Update contributor and language data

* Edited meeting requirement note after feedback

* Update meeting data

* Update contributor and language data

* Applied design system heading classes to Getting Started page (hackforla#2889)

* Apply design system heading classes to Getting Started page

* replaced p tag with h2 tag

* adding blank issue form and renaming blank-issue- to blank-issue-template (hackforla#2899)

* Update blank-issue-form.yml

Removed blank title, labels, and assignees to fix the template so it shows up as an issue template option when creating a new issue.

* removed the extra colons (hackforla#2903)

* Update meeting data

* Update contributor and language data

* updated leadership in ops.yml (hackforla#2894)

* move script to an external javascript file (hackforla#2882)

* Update meeting data

* Update contributor and language data

* Update COP engineering section (hackforla#2905)

* Remove Greg Pawin and add Avali to COP Engineering section

* Change picture to github picture

* Add paragraph classes 1-3 to codebase (hackforla#2880)

* Added variables for the font sizes and line height for the paragraph classes

* Added paragraph classes 1-3

%paragraph-class is a SCSS placeholder class, which has properties that are the same in all the paragraph classes.

* Fixed typo

* Updated Credits file template: Edit content field and remove type field

Clarified the Overview section, added the Details section, and moved the "This issue is tracked in the epic hackforla#2775." to the Resources/Instructions section

* Added the template: Project md file: Removing unused `alt-hero` field

* Update meeting data

* Update contributor and language data

* Clarified meeting times in developer pre-work template

* Added a colon back that was accidentally removed in developers pre-work issue

* Updated column 

Updated column where issues need to be added if there are questions

* Update meeting data

* Update contributor and language data

* Adding info on how to make a PR

* Update meeting data

* Update contributor and language data

* Clarified a couple of sentences in the pre-work developers template

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Refactor of Wins Page Button (hackforla#2918)

* refactor button per css standardization

* revert forms link per request

* Updated dev prework with issue progression with increasing complexity info

* Update meeting data

* Update contributor and language data

* Added/modified pts label to some of the templates

Added/modified pts label to the following templates:
- Credits file template: Edit content field and remove type field
- Pre-work Template - Developers
- Project md file: Removing unused `alt-hero` field
- Project Profile Card review and update

* Edited wording in Project md file: Removing unused `alt-hero` field

* Updated Credits file template: Edit content field and remove type field

* Update meeting data

* Update contributor and language data

* Updated pre-work developer checklist

* Update meeting data

* Update contributor and language data

* Update issue templates

changes spacing

* Update meeting data

* Update contributor and language data

* changed the overview link for the markdown file to show the pdf as em… (hackforla#2772)

* changed the overview link for the markdown file to show the pdf as embedded

* updating the tdm-calculater.md and pdf

* add-priogrm-area-spare-2280 (hackforla#2957)

* add-priogrm-area-spare-2280

* add-priogrm-area-spare-2280

* fixed mispelled word (hackforla#2966)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* lowercase agile.yml file (hackforla#2971)

* Sort events by project (hackforla#2963)

* Refactor events page html script to js file (hackforla#2943)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Removed alt hero from 100-automations.md 2891 (hackforla#2980)

* Fix variable name in citizen-engagement.js (hackforla#2981)

* removed card-body and card-width class (hackforla#2973)

* removed card-body and card-width class

Co-authored-by: scarter31191 <[email protected]>

* Update meeting data

* Update contributor and language data

* Fix alignment of news section on About page (hackforla#2969)

* make changes reflective to Figma design for HfLA in the news

* update the width property on news-cells

* add new width property for desktop view on news-cells

* resolved-issue-2896 (hackforla#2970)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Hide all-time contributors 2605 (hackforla#2967)

* Hide contributors div if number of all time contributors is less than number of people on the current project team

* Add explanatory comment

* Communities of practice info update 2758 (hackforla#2979)

* modify project-management.yml to update project/product management leadership

* book.yml: changed 'content' to 'content-type' and removed 'type' field (hackforla#2983)

* Add program-area field to Green Earth OS (hackforla#2986)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Removed Isaac from website project leadership section (hackforla#2992)

* Update overview link 2238 (hackforla#2995)

* add civic tech overview page to assets folder

* change link in markdown file

* update overview link in markdown

* update link

* revert

* fix link

* fix link

* update links

* update link

* fixes link

* update link

* update link

* fix link again

* fix link again

* Updated alt text to adhere to WCAG (hackforla#2982)

* Update meeting data

* Update contributor and language data

* Update lucky parking project page (hackforla#2991)

* update 311 info page 2987 (hackforla#2994)

* Update meeting data

* Update contributor and language data

* Deleted unused alt-hero field in design-systems.md(hackforla#3000)

* Update project team in guides-team.md (hackforla#2996)

* remove Thuy Le, Carol Zhu, and affiliated links

* CONTRIBUTING.md: stopping mid issue text update (hackforla#2998)

* Modify line 461 CONTRIBUTING.md

* Update meeting data

* Update contributor and language data

* fixed typo for issue hackforla#2911 (hackforla#3006)

* Update meeting data

* Update contributor and language data

* Add issue progression to section 2.1 in CONTRIBUTING.md (hackforla#3007)

* Update project info for Home Unite Us (hackforla#3001)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Fix typo on Citizen Engagement page (hackforla#3013)

* Updated Tools and Current Project Team sections for the Design Systems project profile (hackforla#3012)

* removed tools and leadership members

* added leadership members

* removed unnecessary extra spaces

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Remove alt-hero tag from civic-tech-structure.md (hackforla#3017)

* Add weekly time commitment requirements (hackforla#3015)

* Corrected speeling of 'accommodate' in sitemap html file. (hackforla#3010)

* Update meeting data

* Update contributor and language data

* Change text size for getting started page 2656 (hackforla#2988)

* add-priogrm-area-spare-2280

* add-priogrm-area-spare-2280

* changing text size for Getting Started Page

* change-text-size-for-getting-started-page-2656

* Update meeting data

* Update contributor and language data

* Applied "title3" Classes to Headings. (hackforla#3008)

* added 'title3' class to headings, changed h3 tags to h2 for better semantics

* changed src path for header-hero-image

* Mobile_responsiveness Template to Github Form (hackforla#3014)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Added program area 2384 (hackforla#2790)

* Made changes to spare.md issue 2437

* added program area issue 2384

* Delete spare.md

* Added program area 2384

* Added program area 2384

* Update jobs-for-hope.md

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update issue templates

Updated design template to contain a link to prioritized backlog design issues in the check box section

* Changed label from good first issue to prework for pre-work checklists

* Update meeting data

* Update contributor and language data

* Update food-oasis.md (hackforla#3033)

* Update food-oasis.md

* Add files via upload

adding the pdf for food oasis

* Update food-oasis.md

* Added tools section to current project cards (hackforla#3020)

* Added tools section to current project cards

* Capitalize Tool to match surrounding fields

* Update meeting data

* Update contributor and language data

* added NoSQL.svg to technologies-icons folder (hackforla#3030)

* Added Section 3.1.b.v, How to add a pull request to the project board, to CONTRIBUTING.md (hackforla#3029)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Added The School of law logo issue 3025 (hackforla#3037)

* Update wins card format 2339 (hackforla#2977)

* Fixed "See More" display on wins cards

* Added query in js and functionally mobile "See More" buttons

* Update meeting data

* Update contributor and language data

* Update Pre-work Template - Developers

Clarified that the progress through issues by complexity is to be read and understood, and then can be checked off

* Update meeting data

* Update contributor and language data

* Update design and research pre-work templates with a size label

This is to prevent GHA writing a comment to new members about a missing size label and confusing them.

* Added the time spent so far action item

Added the time spent so far action item

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Updated Community Survey Project .md to accurately display current Pr… (hackforla#3036)

* Updated Community Survey Project .md to accurately display current Project Team leadership.

* Added one current project team member to to the Open Community Survey Project card.

* Added Open Survey Project pdf to website assets. added overview link to open-community-survey.md

* Changed contributer title from 'project manager' to 'product manager. Corrected contributer's github handle.

* Update meeting data

* Update contributor and language data

Co-authored-by: Brian Borin <[email protected]>
Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Providence-o <[email protected]>
Co-authored-by: Anthony Sim <[email protected]>
Co-authored-by: Bonnie Wolfe <[email protected]>
Co-authored-by: Tomas Gonzalez <[email protected]>
Co-authored-by: Frank Stepanski <[email protected]>
Co-authored-by: Lindsey <[email protected]>
Co-authored-by: Jason Yee <[email protected]>
Co-authored-by: Jason Yee <[email protected]>
Co-authored-by: Saumil Dhankar <[email protected]>
Co-authored-by: Carlos <[email protected]>
Co-authored-by: KazushiR <[email protected]>
Co-authored-by: luke-karis <[email protected]>
Co-authored-by: Sparky-code <[email protected]>
Co-authored-by: Gabriel Garcia <[email protected]>
Co-authored-by: Adolf Schmuck <[email protected]>
Co-authored-by: Tamara Snyder <[email protected]>
Co-authored-by: Anna Filatova <[email protected]>
Co-authored-by: Ahmad Tahir <[email protected]>
Co-authored-by: harshitasao <[email protected]>
Co-authored-by: jnmrles <[email protected]>
Co-authored-by: Utkarsh Saboo <[email protected]>
Co-authored-by: Sarah Sanger <[email protected]>
Co-authored-by: Jaretzbalba <[email protected]>
Co-authored-by: Ben Montgomery <[email protected]>
Co-authored-by: Steve Carter <[email protected]>
Co-authored-by: scarter31191 <[email protected]>
Co-authored-by: Poorvi Rao <[email protected]>
Co-authored-by: riddle015 <[email protected]>
Co-authored-by: Matthew Cacho <[email protected]>
Co-authored-by: RyanCahela <[email protected]>
Co-authored-by: kathrynsilvaconway <[email protected]>
@Jaretzbalba Jaretzbalba deleted the update-project-card-tools-2764 branch May 11, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathrynsilvaconway kathrynsilvaconway kathrynsilvaconway approved these changes

@answebdev answebdev answebdev approved these changes

@1anya1 1anya1 Awaiting requested review from 1anya1

@scarter31191 scarter31191 Awaiting requested review from scarter31191

Assignees
No one assigned
Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update project cards to show Tools
6 participants
@Jaretzbalba @1anya1 @answebdev @scarter31191 @JessicaLucindaCheng @kathrynsilvaconway