Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues 1498 #2968

Closed
wants to merge 6 commits into from
Closed

Issues 1498 #2968

wants to merge 6 commits into from

Conversation

1anya1
Copy link
Member

@1anya1 1anya1 commented Mar 11, 2022

Fixes #1498

What changes did you make and why did you make them ?

  • Refactored news container, added new styles according to figma spect both for mobile and web views.
  • Added new class to news container/ wrapped images. to prevent overrides of repeating components

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screen Shot 2022-03-10 at 1 51 42 PM Screen Shot 2022-03-10 at 1 53 29 PM
Visuals after changes are applied Screen Shot 2022-03-10 at 1 54 57 PM Screen Shot 2022-03-10 at 2 06 08 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b 1anya1-issues_1498 gh-pages
git pull https://github.com/1anya1/website.git issues_1498

@github-actions github-actions bot added P-Feature: About Us https://www.hackforla.org/about/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Complexity: Medium labels Mar 11, 2022
@1anya1 1anya1 changed the title Issues 1498 Issues #1498 Mar 11, 2022
@1anya1
Copy link
Member Author

1anya1 commented Mar 11, 2022

@tamara-snyder here is the updated pull request.

@1anya1 1anya1 changed the title Issues #1498 Issues 1498 Mar 11, 2022
@1anya1 1anya1 closed this Mar 11, 2022
@1anya1 1anya1 deleted the issues_1498 branch March 11, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: About Us https://www.hackforla.org/about/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix alignment of News section in About page
1 participant