Edited agile.yml issue 2792 #2965
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
hackforla#2772) * changed the overview link for the markdown file to show the pdf as embedded * updating the tdm-calculater.md and pdf
|
Review ETA: End of day 3/11/22 |
|
Review ETA: 3/11/2022 (end of day) |
There was a problem hiding this comment.
@Benji-Montgomery Thank you for submitting your PR. For this issue, you were supposed to change line 4 from content: Image to content-type: image, as well as remove line 11 for the type field in the file, _data/internal/credits/agile.yml, which I can see that you did. Great job with that!
In the original issue, the word image is lowercase, while you used uppercase in your change (Image). I don't know if this needs to be lowercase as in the original issue, since all of the values in the file use uppercase. Perhaps @SAUMILDHANKAR can chime in when he does his review.
Also, one final thing: Please add this PR to the Project Board. Thank you.
* add-priogrm-area-spare-2280 * add-priogrm-area-spare-2280
There was a problem hiding this comment.
@Benji-Montgomery Thanks for working on this issue. As mentioned by @answebdev, request you to make Image to lowercase image in line4 so it is consistent with the issue requirements. Also, please add your PR to the project board. Once you have made changes, please request a re-review. Thank you.
Fixes #2792
What changes did you make and why did you make them ?
-changed line 4 from content to content-type to make purpose clearer
-removed line 11 because it is redundant
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to website.