Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed alt text for give icon image #2411

Merged
merged 1 commit into from Nov 3, 2021
Merged

changed alt text for give icon image #2411

merged 1 commit into from Nov 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2021

Fixes #1571

What changes did you make and why did you make them ?

I replaced the alt text with a better description

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers Hacktoberfest Issues that can be picked up by people participating in Hacktoberfest role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review labels Oct 31, 2021
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b amnak1284-update-alt-text-give-icon-1571 gh-pages
git pull https://github.com/amnak1284/website.git update-alt-text-give-icon-1571

@abuna1985
Copy link
Member

abuna1985 commented Oct 31, 2021

@amnak1284 Thank you for submitting your first pull request! I have a few requests before we can review this pull request

  1. Per the instructions above, can you please remove the images of the code you have attached in the first comment?
  • Click on the ellipsis (...) on the upper right of the first comment box.
  • Then select Edit in the dropdown menu.
  • Remove the image links

Note: Since this is an alt attribute change, you do not need pictures. The reviews will pull your changes to their computer and check the alt attribute within http:localhost:3000/credits and look for the Give icon.

  1. Can you remove the bullet points from the initial comment in the pull request since you do not need them. This makes the pull request more readable.
-
-
-

Once these edits are completed, we can review this pull request. Again, thank you for contributing to the Hack for LA website repo! 🥇 🥇 🥇

@abuna1985 abuna1985 added the hacktoberfest-accepted Makes a pull request be counted as verified and valid label Oct 31, 2021
@github-actions github-actions bot removed the hacktoberfest-accepted Makes a pull request be counted as verified and valid label Oct 31, 2021
Copy link
Member

@adrian-zaragoza adrian-zaragoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Good job!

@adrian-zaragoza adrian-zaragoza merged commit b6fb4f2 into hackforla:gh-pages Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers Hacktoberfest Issues that can be picked up by people participating in Hacktoberfest role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Alt Text for Give Icon on Credit page
3 participants