Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed GitHub Actions to add labels to an issue in a specific column weekly #2006

Merged
merged 14 commits into from
Aug 4, 2021

Conversation

Aveline-art
Copy link
Member

@Aveline-art Aveline-art commented Jul 24, 2021

Fixes #1956

What changes did you make and why did you make them ?

  • Added a series of files for a GHA that adds a certain label to all issues in a certain column, including:
    • the yml file that houses the action
      • this action uses a newly made secret key that skips several API calls to retrieve information from a column
    • the main script (addLabel.js) which performs the action
    • a utility script (findLinkedIssue.js) which was extracted from a previous GHA
  • Kept the trigger as workflow_dispatch to facilitate testing. Once the tests are passed, it should be swapped to an on-schedule trigger.
  • Commented out code that posts comments so that testing would not disturb our team

Tests to perform after merging:

  • Manually run the script and check the logs, which indicates the action the script took for every issue. Reference, maybe, a random 20% of the issues, to check that the labels were added correctly.

Note: this GHA right now is quite heavy (over 200 lines!) because the many API calls required to retrieve the relevant data. I think the natural evolution of this script to clean up the code is to adopt GitHub's GraphQLv4API, whenever it becomes more accessible.

@github-actions github-actions bot added automation for manulal github board maintenance actions that are going to be automated Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers Complexity: Large labels Jul 24, 2021
@github-actions
Copy link

From your project repository, check out a new branch and test the changes.

git checkout -b Aveline-art-weekly-update-labels gh-pages
git pull https://github.com/Aveline-art/website.git weekly-update-labels

@Aveline-art
Copy link
Member Author

Per this comment, this GHA cannot be ready to merge until design decisions are made. Therefore, this PR will remain as a draft, indefinitely until the design is resolved.

@Aveline-art Aveline-art marked this pull request as draft July 25, 2021 20:45
Copy link
Member Author

@Aveline-art Aveline-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits!

github-actions/add-update-label-weekly/addLabel.js Outdated Show resolved Hide resolved
github-actions/add-update-label-weekly/addLabel.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added role: design and removed role: back end/devOps Tasks for back-end developers labels Aug 2, 2021
@Aveline-art
Copy link
Member Author

@averdin2 @abuna1985 Just a heads up. I'd like to have this out of draft by the end of today and merged before Friday so that the trial can happen. If you'd like to look this over and relay comments, between Tues-Thurs is your chance!

@Aveline-art Aveline-art marked this pull request as ready for review August 2, 2021 20:54
@Aveline-art Aveline-art merged commit 5497113 into hackforla:gh-pages Aug 4, 2021
@Aveline-art
Copy link
Member Author

Notes:

#2040 is marked because a timeline is outdated by default unless proven otherwise. Without a timeline to reference, we cannot check for outdatedness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation for manulal github board maintenance actions that are going to be automated Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions: Automate In Progress Issue Updates: Add Update Label
1 participant