Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Request for Update of Hack for LA's Current GHA's Documentation #4728

Closed
4 of 5 tasks
karengcecena opened this issue May 25, 2023 · 3 comments
Closed
4 of 5 tasks
Assignees
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Feature: Wiki Issue Making: Level 2 Make issue(s) from an ER or Epic role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@karengcecena
Copy link
Member

karengcecena commented May 25, 2023

Emergent Requirement - Problem

  • The current Hack for LA's Current GHA's Documentation is missing a lot of the GHAs currently found in the website repository.
  • I believe it would be beneficial to 1) organize the GHA to be in the same order as presented within the github-actions folder and also add the GHA that are missing.

This is the current structure of the GHA Documentation:

move-closed-issues

  • sort-closed-issues.js

pr-instructions

  • create-instructions.js
  • post.comment.js

trigger-issue

  • /add-missing-labels-to-issue
    • check-labels.js
    • post-labels-comment.js
  • /add-preliminary-comment
    • check-label-preliminary-update.js
    • preliminary-update-comment.js

trigger-pr

  • set-pr-labels.js

trigger-schedule

  • /add-update-label-weekly
    • add-label.js
  • /github-data
    • get-project-data.js
  • /list-inactive-members
    • comment-issues.js
    • create-new-issue.js
    • get-list.js
  • /trim-contributers
    • contributors-data.js

utils

  • find-linked-issue.js
  • obtain-labels.js

These are the current GitHub actions and what I think they correspond to:

add update label weekly

  • add-label.js in trigger-schedule/add-update-label-weekly

github data

  • get-project-data.js in trigger-schedule/github-data
  • I really like how this one stated the js folder first thing in the summary

issue trigger

  • uses obtain-labels.js in utils folder
  • I think it is supposed to be about check-labels.js and post-labels-comment.js in trigger-issue/add-missing-labels-to-issue
    • I think the documentation could be a lot stronger/ more specific about each .js file

lint-scss

move closed issues

  • sort-closed-issues.js in move-closed-issues

pr instructions

  • create-instructions.js and post.comment.js in pr-instructions

pull request trigger

set pr labels

update team members (NOT FOUND?)

vrms data

wr pr instructions

wr pull request trigger

wr set pr labels

Deprecated GHAs

no-labels-template.md

  • in trigger-issue/add-missing-labels-to-issue

That leaves these within github-actions without any sort of documentation:

trigger-issue

  • /add-preliminary-comment
    • check-label-preliminary-update.js
    • preliminary-update-comment.js

trigger-schedule

  • /list-inactive-members
    • comment-issues.js
    • create-new-issue.js
    • get-list.js
  • /trim-contributers
    • contributors-data.js

utils

  • find-linked-issue.js

These are also In the Workflow Folder but not in the documentation:

Issue you discovered this emergent requirement in

Date discovered

  • 04/20/2023

Did you have to do something temporarily

  • YES
  • NO

Who was involved

  • n/a

What happens if this is not addressed

  • A lot of time is wasted with missing issues on the documentation. I had to go to the website code specifically and search through each GHA to try and complete my issue. I feel like it would be more beneficial for everyone to have the documentation be up to date with some re-organization to make it easily understandable.

Resources

  • n/a

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

Create an issue that has someone:

1) Order the GHA Documentation - I think an order that would make sense could be something like:

/gitub-actions

/.github/workflows

2) Add the missing GHA:

trigger-issue

  • /add-preliminary-comment
    • check-label-preliminary-update.js
    • preliminary-update-comment.js

trigger-schedule

  • /list-inactive-members
    • comment-issues.js
    • create-new-issue.js
    • get-list.js
  • /trim-contributers
    • contributors-data.js

utils

  • find-linked-issue.js

3) Add the missing workflows:

@karengcecena karengcecena added the size: 0.25pt Can be done in 0.5 to 1.5 hours label May 25, 2023
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels May 25, 2023
@karengcecena karengcecena changed the title ER: Hack for LA's Current GHA's Documentation is Out of Date ER: Request for Update of Hack for LA's Current GHA's Documentation May 25, 2023
@wanyuguan wanyuguan added this to the 08. Team workflow milestone May 28, 2023
@ExperimentsInHonesty ExperimentsInHonesty added role: back end/devOps Tasks for back-end developers and removed role missing labels Jun 4, 2023
@roslynwythe roslynwythe self-assigned this Jun 13, 2023
@github-actions
Copy link

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe roslynwythe added Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. Complexity: Missing labels Jun 15, 2023
@roslynwythe
Copy link
Member

@kimberlytanyh kimberlytanyh added the ER Emergent Request label Sep 10, 2023
@roslynwythe roslynwythe added Complexity: Medium size: 1pt Can be done in 4-6 hours Issue Making: Level 2 Make issue(s) from an ER or Epic Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours Complexity: Medium labels Oct 12, 2023
@roslynwythe
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Feature: Wiki Issue Making: Level 2 Make issue(s) from an ER or Epic role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

No branches or pull requests

5 participants