Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-labels-template.md file #2898

Closed
6 tasks done
Tracked by #3849
SAUMILDHANKAR opened this issue Feb 27, 2022 · 9 comments · Fixed by #3348
Closed
6 tasks done
Tracked by #3849

Remove no-labels-template.md file #2898

SAUMILDHANKAR opened this issue Feb 27, 2022 · 9 comments · Fixed by #3348
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less

Comments

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Feb 27, 2022

Overview

We need to remove no-labels-template.md file so that the total number of bot comments are reduced, and developers would have less notifications

Action Items

Checks

  • For testing in your own repo (after making the necessary code changes)
    • Create a project board in your own repo
    • Create a new issue with all the required labels, i.e., (role, size and feature) and submit the issue
    • Confirm that no comment is posted by the bot

Resources/Instructions

Directory where files are located website/github-actions/trigger-issue/add-missing-labels-to-issues/
File that needs to be removed no-labels-template.md
File where changes need to be made: post-labels-comment.js
Never done GitHub actions? Start here!
GitHub Complex Workflows doc
GitHub Actions Workflow Directory
Events that trigger workflows
Workflow syntax for GitHub Actions
actions/github-script
GitHub RESTAPI

@SAUMILDHANKAR SAUMILDHANKAR added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.5pt Can be done in 3 hours or less labels Feb 27, 2022
@github-actions
Copy link

Hi @SAUMILDHANKAR.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

Hi @oliviaywangn, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@oliviaywangn oliviaywangn removed their assignment Jul 3, 2022
@raswani2023 raswani2023 self-assigned this Jul 3, 2022
@github-actions
Copy link

github-actions bot commented Jul 3, 2022

Hi @raswani2023, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jul 8, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

@raswani2023

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, July 5, 2022 at 12:19 AM PST.

@raswani2023
Copy link
Member

ETA: Just submitted a PR for the issue after being able to test it in my local repository to make sure the changes worked.
Availability: Monday, Tuesday, Wednesday

@ExperimentsInHonesty
Copy link
Member

Which GHA are you working on. See this directory: https://github.com/hackforla/website/wiki/HfLA-GitHub-Actions

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Nov 27, 2022

I just looked at the PR and it looks like one file was deleted and another had all the logic removed from a function. Is there a reason why we didn't delete the function? Not advocating that, just asking for a second look to make sure we cleaned up what we were intending to, and that This change needs to be properly documented in the wiki and in this issue. See my question from the 12th.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Nov 27, 2022
@ExperimentsInHonesty
Copy link
Member

Please make a new issue to document this change appropriately in the wiki, GHAs, which should include marking a GHA as depreciated with details why.

@jdingeman
Copy link
Member

jdingeman commented Jan 22, 2023

Please make a new issue to document this change appropriately in the wiki, GHAs, which should include marking a GHA as depreciated with details why.

@jdingeman jdingeman removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

5 participants