GitHub Actions: Bot adding and removing the same label #2650
Comments
github-actions
bot
added
Feature Missing
|
Hi @SAUMILDHANKAR. Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: To add a label, take a look at Github's documentation here. Also, don't forget to remove the "missing labels" afterwards. After the proper labels are added, the merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization. Additional Resources: |
SAUMILDHANKAR
added
role: back end/devOps
SAUMILDHANKAR
changed the title
SAUMILDHANKAR
changed the title
SAUMILDHANKAR
added
automation
SAUMILDHANKAR
changed the title
|
I checked the pull request and I don't think this is a code issue. The person accidentally wrote the wrong issue number whose labels were pulled for the pull request and then changed it to the correct one which led to the GitHub action removing some of the previous labels while keeping the others as the two issues shared some labels in common. |
|
@Zak234 Thanks for adding your analysis for this issue. Looks like your observation is correct for the case mentioned in the issue description above however, there are a few more cases where the labels are getting added unexpectedly and sorry, I did not add them to the issue earlier. Please notice that the GitHub action bot adds and removes the same label in:
It would be really helpful if these can be analyzed as part of this issue as well by reopening this issue, but if you think a separate issue would be better to resolve it, let me know. Additionally, GitHub actions bot sometimes removes a label unexpectedly. See the cases below:
These might not be related but just wanted to add it here in case it is useful. I will reach out to you on slack as well for better reach. Thanks. |
|
I took a look at them and it looks like the first five have an issue
with add-update-label-weekly.yml
while the last two have an issue with issue-trigger.yml. I'll take a closer
look at the files but I also wanted to ask if you had any more recent
examples of the GitHub bot adding and removing update labels as the five
are all from last year and there may have been updates to the action in the
meantime that solved the issue.
…On Sat, Jun 25, 2022 at 2:02 AM Saumil Dhankar ***@***.***> wrote:
@Zak234 <https://github.com/Zak234> Thanks for adding your analysis for
this issue. Looks like your observation is correct for the case mentioned
in the issue description above however, there are a few more cases where
the labels are getting added unexpectedly and sorry, I did not add them to
the issue earlier. Please notice that the GitHub action bot adds and
removes the same label in:
- #2462 <#2462> on Dec 9
- #2497 <#2497> on Dec 2
- #2561 <#2561> on Jan 20
- #2397 <#2397> on Dec 23
- #2317 <#2317> on Dec 9
It would be really helpful if these can be analyzed as part of this issue
as well by reopening this issue, but if you think a separate issue would be
better to resolve it, let me know.
Additionally, GitHub actions bot sometimes removes a label unexpectedly.
See the cases below:
- #2676 <#2676> on Jan 8
- #2397 <#2397> on Oct 25
These might not be related but just wanted to add it here in case it is
useful. I will reach out to you on slack as well for better reach. Thanks.
—
Reply to this email directly, view it on GitHub
<#2650 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUP35A2SYFH3MSKVMWKWEWDVQ3DMBANCNFSM5LDQOOXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Zak234 Thanks for getting back. There have been a few updates to the actions that you mentioned above but none of them seems to be directly about fixing this issue. It is possible that any other code change might have fixed this issue, but it would need more analysis. I will check my notes for a more recent example where this has occurred and let you know. Thank you. |
|
Let me know if you can find any more recent examples. I also wanted to make
sure that for the issue where its removing the milestone label that both
you and Adam are part of merge team, right? I'm going to be gone for the
next five days but I'll get back to this when available again.
…On Sun, Jun 26, 2022 at 4:58 PM Saumil Dhankar ***@***.***> wrote:
@Zak234 <https://github.com/Zak234> Thanks for getting back. There have
been a few updates to the actions that you mentioned above but none of them
seems to be directly about fixing this issue. It is possible that any other
code change might have fixed this issue, but it would need more analysis. I
will check my notes for a more recent example where this has occurred and
let you know. Thank you.
—
Reply to this email directly, view it on GitHub
<#2650 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUP35AZ2LARYVINFRJGB5QLVRDVEDANCNFSM5LDQOOXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Zak234 I was definitely part of the merge team when the label was removed and as far as I can remember Adam was part of the merge team as well though not 100% sure. |
|
I took a closer look at the issue where it removed the "Ready for
Milestone" label and it looks like the issue is that when the issue trigger
runs that the check-labels.js file doesn't check if the issue creator is
part of the merge team and instead just considers the "Ready for Milestone"
label as an unwanted label all the time and removes it. I can write an
issue for it if you want.
…On Fri, Jul 1, 2022 at 5:11 PM Saumil Dhankar ***@***.***> wrote:
@Zak234 <https://github.com/Zak234> I was definitely part of the merge
team when the label was removed and as far as I can remember Adam was part
of the merge team as well though not 100% sure.
—
Reply to this email directly, view it on GitHub
<#2650 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUP35A5NB5N3SFVVW2RGLJDVR6CMVANCNFSM5LDQOOXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I talked with Bonnie in standup and she told me to go ahead and create the
issue, if thats okay with you?
On Sun, Jul 3, 2022 at 1:15 PM Sakari Salminiitty <
***@***.***> wrote:
… I took a closer look at the issue where it removed the "Ready for
Milestone" label and it looks like the issue is that when the issue trigger
runs that the check-labels.js file doesn't check if the issue creator is
part of the merge team and instead just considers the "Ready for Milestone"
label as an unwanted label all the time and removes it. I can write an
issue for it if you want.
On Fri, Jul 1, 2022 at 5:11 PM Saumil Dhankar ***@***.***>
wrote:
> @Zak234 <https://github.com/Zak234> I was definitely part of the merge
> team when the label was removed and as far as I can remember Adam was part
> of the merge team as well though not 100% sure.
>
> —
> Reply to this email directly, view it on GitHub
> <#2650 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUP35A5NB5N3SFVVW2RGLJDVR6CMVANCNFSM5LDQOOXQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@Zak234 Thanks for looking into it. I will let you and the current leads decide on if a new issue should be written for it or if it should be fixed as part of this issue. Also, were you able to look into the other issues as well where the GitHub actions bot was adding and removing the status updated label? If these are 2 separate problems, then making a new issue would definitely be a good idea. |
|
I believe that they are 2 separate separate issues. I'll take a closer look
at the status updated issue.
…On Tue, Jul 5, 2022 at 7:01 PM Saumil Dhankar ***@***.***> wrote:
@Zak234 <https://github.com/Zak234> Thanks for looking into it. I will
let you and the current leads decide on if a new issue should be written
for it or if it should be fixed as part of this issue.
Also, were you able to look into the other issues as well where the GitHub
actions bot was adding and removing the status updated label? If these are
2 separate problems, then making a new issue would definitely be a good
idea.
—
Reply to this email directly, view it on GitHub
<#2650 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUP35A2O4AICYWOOFFFZOBDVSTSJHANCNFSM5LDQOOXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I found some more recent issues with the status updated issue, so it looks
like it was never fixed. I can create a new issue for it but I was also
wondering if the To Update! label is still in use as it was also being
added and removed but I can find only one current issue with the label and
its 2 months old.
On Tue, Jul 5, 2022 at 7:06 PM Sakari Salminiitty <
***@***.***> wrote:
… I believe that they are 2 separate separate issues. I'll take a closer
look at the status updated issue.
On Tue, Jul 5, 2022 at 7:01 PM Saumil Dhankar ***@***.***>
wrote:
> @Zak234 <https://github.com/Zak234> Thanks for looking into it. I will
> let you and the current leads decide on if a new issue should be written
> for it or if it should be fixed as part of this issue.
>
> Also, were you able to look into the other issues as well where the
> GitHub actions bot was adding and removing the status updated label? If
> these are 2 separate problems, then making a new issue would definitely be
> a good idea.
>
> —
> Reply to this email directly, view it on GitHub
> <#2650 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUP35A2O4AICYWOOFFFZOBDVSTSJHANCNFSM5LDQOOXQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@Zak234 Thanks for looking into this. Sure, feel free to create an issue for that. Unless something came up regarding the To update! label recently, my understanding is that it is still being used. The reason there aren't too many of those labels currently might be because of a bug which would be addressed in the issue: #2634 |
|
Okay, thank you!
…On Sun, Jul 10, 2022 at 12:55 PM Saumil Dhankar ***@***.***> wrote:
@Zak234 <https://github.com/Zak234> Thanks for looking into this. Sure,
feel free to create an issue for that. Unless something came up regarding
the To update! label recently, my understanding is that it is still being
used. The reason there aren't too many of those labels currently might be
because of a bug which would be addressed in the issue: #2634
<#2634>
—
Reply to this email directly, view it on GitHub
<#2650 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUP35A4245ALHGU4DOHGPPTVTMTC7ANCNFSM5LDQOOXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Overview
As a developer, we have to ensure that our kanban board is organized for all teams so that productivity is high. For this issue, we want to know why the GitHub action bot is adding and removing the same label and change the code logic so it doesn't do that.
Action Items
Checks
Resources/Instructions
Screenshot of pr #2621 showing github-actions adding and removing labels "role: back end/devOps" and "Size: Large"
Never done GitHub actions? Start here!
GitHub Complex Workflows doc
GitHub Actions Workflow Directory
Events that trigger workflows
Workflow syntax for GitHub Actions
actions/github-script
GitHub RESTAPI
Architecture Notes
The idea behind the refactor is to organize our GitHub Actions so that developers can easily maintain and understand them. Currently, we want our GitHub Actions to be structured like so based on this proposal:
- Schedule Friday 0700
- Schedule Thursday 1100
- Schedule Daily 1100
- Lint SCSS
- Add Linked Issue Labels to Pull Request
- Add Pull Request Instructions
- Add Missing Labels To Issues
- WR Add Linked Issue Labels to Pull Request
- WR Add Pull Request Instructions
Actions with the same triggers (excluding linters, which will be their own category) will live in the same github action file. Scheduled actions will live in the same file if they trigger on the same schedule (i.e. all files that trigger everyday at 11am will live in one file, while files that trigger on Friday at 7am will be on a separate file).
That said, this structure is not set in stone. If any part of it feels strange, or you have questions, feel free to bring it up with the team so we can evolve this format!
The text was updated successfully, but these errors were encountered: