Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email capabilities to public comment page #658 #705

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

nclairesays
Copy link
Member

@nclairesays nclairesays commented Jan 14, 2021

closes #658

When running git commit command, got this error:
image

When I tried installing husky as instructed, it kept trying to run npm run lint on this file node_modules/asn1.js. But because this supposed to be ignored, it kept erroring out.

I managed to get it to commit and push but if you can double check on the linting, that would be helpful. Thank you!

@nclairesays nclairesays force-pushed the 656-public-comment-email-forwarding branch from da0ed8a to 9327b72 Compare January 14, 2021 07:35
@nclairesays nclairesays changed the title Add email capabilities to public comment page #656 Add email capabilities to public comment page #705 Jan 14, 2021
@nclairesays nclairesays changed the title Add email capabilities to public comment page #705 Add email capabilities to public comment page #658 Jan 14, 2021
@nclairesays nclairesays force-pushed the 656-public-comment-email-forwarding branch from 9327b72 to 00685b9 Compare January 14, 2021 07:47
Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, including the linting.
Since re-organization of the folder structure and adding the git commit hook,
you need to run npm install on the root folder the server folder and the client folder.
My first guess is that you have not run npm install on the root folder, which would install
husky, which the git commit hook needs to run linting when you attempt a commit.
You can run lint on both server and client by running

lerna run lint

I need to modify the developer documentation to add some instructions about this, as well as some quirks on Windows machines that I discovered when setting up a new Windows laptop.

@entrotech entrotech merged commit 9c1dc51 into develop Jan 14, 2021
@nclairesays nclairesays deleted the 656-public-comment-email-forwarding branch July 15, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up email forwarding on comment form
2 participants