Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand authorization validation for Project CRUD operations #328

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

nclairesays
Copy link
Member

@nclairesays nclairesays commented Mar 31, 2020

closes #309
added backend logic to check if the requester of a PUT, POST, or DELETE request is an authorized user of that project or an admin user

  • previously, you could create or delete a project with anybody's login id via postman if you add their loginId in the request body
  • now, it checks to make sure that the loginId in the request body is the same as the user's id who is logged and if the user is an admin for PUT, POST, and DELETE
    I also updated existing delete path to include /:id params

Refactor/Code Cleanup: deleted unused files (playground and auth.service.js)

Related issues:
#302
#275 (which is only related to view access)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to do CRUD operations on their own projects
2 participants