Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeke download csv and print pdf #1508

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Zeke download csv and print pdf #1508

merged 7 commits into from
Nov 16, 2023

Conversation

ZekeAranyLucas
Copy link
Member

Fixes #1420 and #1393

What changes did you make?

1420 + 1393 - download projects as CSV and PDF
* add ProjectTableRow component
* dynamically load rules on init
* enable download CSVs on menu with CSVLink
* enable print PDF on menu with PdfPrint
* switch cursor to hand/pointer on menu
* update trash and copy icons to use SVG (pretty!)
Tests
* add ProjectRowTable tests for conditional state
* updated svg icons to use title for testing and a11y
* all tests need "await waitFor"
* fixed tests for tdm-engine, NavBar, Level0Page
* fixed tests for postPublicComment
* skipped tests for PublicComentPage

TODO: decide about whether to use codes or names for column values in CSV file.
we should check it out in practice and then make a call.

Why did you make the changes (we will use this info to test)?

check issues for details.

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

no screenshots, but the icons do look better. probably need to add hover effects to the menu, too.

* add ProjectTableRow component
* dynamically load rules on init
* enable download CSVs on menu with CSVLink
* enable print PDF on menu with PdfPrint
* switch cursor to hand/pointer on menu
* update trash and copy icons to use SVG
* updated svg icons to use title for testing and a11y
* all tests need "await waitFor"
and Level0Page.test.jsx
* fixed tests for postPublicComment
* skipped tests for PublicComentPage
@ZekeAranyLucas
Copy link
Member Author

ZekeAranyLucas commented Nov 13, 2023

UPDATED: OK to merge. Verified this existed before my changes, so not a regression. created #1512 to trace.

Hold off merging. Looks like I introduced a regression.

when navigating from "Create Project" or "Feedback" to "My Projects" this toast error:

ERROR
ResizeObserver loop completed with undelivered notifications.
    at handleError (http://localhost:3000/static/js/bundle.js:128757:58)
    at http://localhost:3000/static/js/bundle.js:128776:7

doesn't repro on refresh of "MyProjects" or navigation from "About" and "FAQ".

Might be something to do with scroll bars

while debugging ResizeObserver error
Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I'll create a follow-up issue about re-arranging some of the columns on the CSV format - we want to include some information from the product object, and omit columns that are intermediate calculations, and order the columns in roughly the order they appear in the calculation wizard. We'll assign it to someone else.

@entrotech entrotech merged commit 4c16478 into develop Nov 16, 2023
1 check passed
entrotech added a commit that referenced this pull request Nov 16, 2023
@entrotech entrotech mentioned this pull request Nov 16, 2023
entrotech added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a "Download to CSV" feature
2 participants