Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace html elements with MUI in editableField.jsx #1849

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

dannyprikaz
Copy link
Member

Fixes #1700

Note:

This seems to be an unused component, but I went ahead and made the changes anyways.

What changes did you make and why did you make them ?

  • Replaced HTML div tag with MUI Box componenet
  • Replaced HTML button tag with MUI Button component
  • Replaced HTML textarea tag with MUI TextareaAutosize component
  • Replaced HTML input tag with MUI TextField component
  • WHY: To modernize the editableMeeting.jsx component using MUI

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

1700 pre no-edit mode
1700 pre edit mode

Visuals after changes are applied

1700 post no-edit mode
1700 post edit mode

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b dannyprikaz-issue1700-editable-fileds-mui development
git pull https://github.com/dannyprikaz/VRMS.git issue1700-editable-fileds-mui

Copy link
Member

@sasszz sasszz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low risk because it is an unused component, approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/manageProjects/editableField.js
3 participants