Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

904 Council Multiselect #996

Merged
merged 14 commits into from
Mar 11, 2021
Merged

904 Council Multiselect #996

merged 14 commits into from
Mar 11, 2021

Conversation

adamkendis
Copy link
Member

@adamkendis adamkendis commented Mar 4, 2021 •
edited
Loading

Fixes #904
Fixed #973

  • SearchBar component

  • Filterable multiselect components

  • Council multiselect - at the moment, unsure if this will be used in final menu design. To discuss at team meeting tonight 3/4/21.

  • Listener fix in PersistentDrawerLeft.

    • Up to date with dev branch
    • Branch name follows guidelines
    • All PR Status checks are successful
    • Peer reviewed and approved

Any questions? See the getting started guide

adamkendis and others added 14 commits February 18, 2021 17:24
@adamkendis
SelectItem, SelectGroup, GroupedMultiSelect components
e87dfd6
@adamkendis
added not util function
ea9e861
@adamkendis
SearchBar component
1f27b05
@adamkendis
update theme, StyledChip styles
5bddbdc
@adamkendis
clean up reducers, update council reducer
7d7006d
@adamkendis
CouncilSelector component
a7ac42b
@adamkendis
added bottom padding to SearchBar wrapper
c69f3ca
@adamkendis
filtering wip
5165e91
@rufataliy
Added closeMenu redux method to close menu on 'on Escape clikc'
afa65e3
@rufataliy
Removed preventDefault which caused SearchBar onChange event not to f…
8710971 
…ire. Changed keypress to keyup to capture escape click
@adamkendis
Merge pull request #974 from hackforla/973-onChangeBug-FRONT
c2e84e7 
973 on change bug front
@adamkendis
Merge branch '904-FRONT-council-multiselect' of https://github.com/ha…
5a50087 
…ckforla/311-data into 904-FRONT-council-multiselect
@adamkendis
linting
2c78efa
@adamkendis
more linting
fd00c38
@adamkendis adamkendis added the Do Not Merge Do not merge this PR, it is likely blocked by something else label Mar 4, 2021
@adamkendis adamkendis added this to the Initial v2 Launch milestone Mar 4, 2021
@adamkendis adamkendis removed the Do Not Merge Do not merge this PR, it is likely blocked by something else label Mar 11, 2021
@adamkendis adamkendis merged commit 9d4c55a into dev Mar 11, 2021
@adamkendis adamkendis deleted the 904-FRONT-council-multiselect branch March 11, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
P: 311: Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onChange is not firing for SearchBar Council Multiselect (advanced/desktop)
2 participants
@adamkendis @rufataliy