Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding postgis and council geojson #910

Merged
merged 3 commits into from
Jan 27, 2021
Merged

adding postgis and council geojson #910

merged 3 commits into from
Jan 27, 2021

Conversation

mattyweb
Copy link
Collaborator

Fixes #909

Adding PostGIS support
Adding council GeoJSON and endpoint (/geojson) for client

@mattyweb mattyweb requested a review from adamkendis January 26, 2021 23:43
@mattyweb
Copy link
Collaborator Author

I need to add some tests.
And probably rename some stuff.

@jafow
Copy link
Member

jafow commented Jan 27, 2021

Looking good to me. I do not have enough context I think to be generally helpful but I think the setup here is 👌👌

Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only thing I noticed was that some of the precision on the coordinates has been lost, but I really don't know if we even need something like 14-16 decimal places on lat/lng. Couple comparison snippets below. Not sure if that's caused by casting geometry to string or something else. We can put it on dev and see how it looks in the client.

seeds/nc-boundary-geojson.json
nc_id: 6

"coordinates": [
  [
    [
      [
          -118.45005171864273,
          34.249915100597775
      ],
      [
          -118.45055441819916,
          34.2506346000586
      ],
      [
          -118.451585617486,
          34.2516467005137
      ],

sample json response you sent in slack
nc_id: 6

"coordinates": [
  [
    [
      [
        -118.450051719,
        34.249915101
      ],
      [
        -118.450554418,
        34.2506346
      ],
      [
        -118.451585617,
        34.251646701
      ],

@mattyweb
Copy link
Collaborator Author

per discussion on Slack, i think we're OK with losing some precision here (I think it was false accuracy).

i've also decided to push a separate PR to add some tests...there's some other stuff i want to refactor there anyway.

@mattyweb mattyweb merged commit 6ef107f into dev Jan 27, 2021
@mattyweb mattyweb deleted the 909-feat-serve-geojson branch January 27, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Load council geometries and serve geojson from API
3 participants