Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Panel Tweak #815

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Accessibility Panel Tweak #815

merged 4 commits into from
Oct 5, 2020

Conversation

tan-nate
Copy link
Contributor

@tan-nate tan-nate commented Sep 25, 2020

Tweaked Accessibility Panel styling so it scrolls to the bottom of the panel in a minimized screen. Also 'Shift', 'Tab', and 'Alt' key presses do not toggle the Hamburger Menu or Accessibility Dropdown

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@tan-nate tan-nate requested a review from adamkendis September 25, 2020 02:03
@tan-nate tan-nate changed the title tweaked styling to accessibility panel so it scrolls to the end in mi… Accessibility Panel Tweak Sep 25, 2020
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nate, good stuff. Just a comment on flipping the keypress handling.

client/components/main/header/AccessibilityPane.jsx Outdated Show resolved Hide resolved
client/components/main/header/Header.jsx Outdated Show resolved Hide resolved
@tan-nate tan-nate requested a review from adamkendis October 3, 2020 21:11
@adamkendis adamkendis merged commit 6a5cfaa into dev Oct 5, 2020
@adamkendis adamkendis deleted the FRONT-AccessibilityPanelTweak branch October 5, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants