Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverting dates on request detail #794

Merged
merged 2 commits into from
Aug 26, 2020
Merged

coverting dates on request detail #794

merged 2 commits into from
Aug 26, 2020

Conversation

mattyweb
Copy link
Collaborator

Fixes #793

converting datetimes. the strange thing is i'm not sure how this behavior changed. must have been in some library upgrade.

jmensch1
jmensch1 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep seems like an upgrade issue

I removed the self argument from all the controller methods, which fixed the postman tests. Those methods are all static methods (not instance methods), so they don't take a self as the first arg.

@jmensch1 jmensch1 merged commit 8034c75 into dev Aug 26, 2020
@jmensch1 jmensch1 deleted the 793-tooltip-bug branch August 26, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmensch1 jmensch1 jmensch1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEV SITE: pin tools tips not working
2 participants
@mattyweb @jmensch1