Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Mapbox attribution #752

Merged
merged 6 commits into from
Jul 21, 2020
Merged

Updated Mapbox attribution #752

merged 6 commits into from
Jul 21, 2020

Conversation

tan-nate
Copy link
Contributor

@tan-nate tan-nate commented Jul 20, 2020 •
edited
Loading

Fixes #738

Updated the text Mapbox text attribution and added a Mapbox wordmark

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@tan-nate tan-nate linked an issue Jul 20, 2020 that may be closed by this pull request
Update map attribution #738
Closed
2 tasks
@tan-nate tan-nate changed the title 738-FRONT-UpdateMapAttribution Updated Mapbox attribution Jul 20, 2020
jmensch1
jmensch1 reviewed Jul 20, 2020
View reviewed changes
src/styles/map/_map.scss Outdated Show resolved Hide resolved
jmensch1
jmensch1 suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tan-nate, looks great. Left one little request about z-indexes but otherwise this is good to go.

@tan-nate tan-nate requested a review from jmensch1 July 20, 2020 22:29
jmensch1
jmensch1 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff! thanks

@jmensch1 jmensch1 merged commit 5118a5b into dev Jul 21, 2020
@jmensch1 jmensch1 deleted the 738-FRONT-UpdateMapAttribution branch July 21, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmensch1 jmensch1 jmensch1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update map attribution
2 participants
@tan-nate @jmensch1