Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back more cleanup #727

Merged
merged 6 commits into from
Jul 2, 2020
Merged

Back more cleanup #727

merged 6 commits into from
Jul 2, 2020

Conversation

jmensch1
Copy link
Contributor

@jmensch1 jmensch1 commented Jul 1, 2020

This is all project cleanup stuff. There are no code changes (unless you count .gitignore as code). Here's the rundown:

AWS Stuff

I wrote a README in /server/aws that describes our setup. Also I moved all of the terraform files from /Orchestration into /server/aws. We're not using them right now, but they might be useful later.

Jmeter

Updated the jmeter tests since they were using using endpoints that no longer exist. Also updated the README in /server/jmeter.

Deleted /Orchestration

There's nothing in there we need. The docker-compose.yml file now lives in /server.

Deleted unused files

These include .flake8 and .dockerignore in the root.

.gitignore cleanup

Our .gitignore had all kinds of stuff that didn't seem to be doing anything. I cleaned it up, and also added a .gitignore in /server that deals with backend stuff.

Updated docs

I updated the README and GETTING_STARTED docs in the root to reflect the current reality of the project.

Created misc folder for stuff we don't know what to do with

I renamed /Documentation to /misc since it has a bunch of stuff in it that isn't documentation. I also moved all of our inactive workflows into that folder. This is what it looks like:

Screen Shot 2020-07-01 at 9 16 50 AM

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jmensch1 jmensch1 requested a review from adamkendis July 1, 2020 16:24
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great READMEs.

@adamkendis adamkendis merged commit bafd47e into dev Jul 2, 2020
@adamkendis adamkendis deleted the BACK-MoreCleanup branch July 2, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants