Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend cleanup and favicon #720

Merged
merged 7 commits into from
Jul 1, 2020
Merged

Frontend cleanup and favicon #720

merged 7 commits into from
Jul 1, 2020

Conversation

adamkendis
Copy link
Member

Fixes #711

Minor frontend .env changes, cleanup, and addition of a favicon.

.env changes

  • Moved .example.env / .env to /src and updated webpack Dotenv plugin re same.
  • Removed REACT_APP prefix from MAPBOX_TOKEN since we aren't using CRA.
  • Renamed DB_URL to API_URL to be correctly descriptive.
  • Moved hardcoded map layer URLs to .example.env / .env.

Mapbox streets tile layer

  • Replaced the deprecated mapbox.streets Classic style layer with the Modern streets-v11 style. The modern streets layer differs from the classic style in a few ways, namely text scaling. Will confer with UI re tweaking the style before using the new streets layer in production.

Favicon

Misc

  • Removed several obsolete files including frontend Dockerfile, copyEnv.sh (used by the Dockerfile), unused server.js, and remaining CRA files (React favicon, manifest.json).
  • Moved misc images to Documentation for now. Not sure if these were generated by the data team or if they're needed for any reason.
  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@adamkendis adamkendis added the Do Not Merge Do not merge this PR, it is likely blocked by something else label Jul 1, 2020
@adamkendis adamkendis removed the Do Not Merge Do not merge this PR, it is likely blocked by something else label Jul 1, 2020
@adamkendis adamkendis requested a review from jmensch1 July 1, 2020 01:24
jmensch1
jmensch1 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great! The repo's getting way more manageable.

@adamkendis adamkendis merged commit 0ea8159 into hackforla:dev Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmensch1 jmensch1 jmensch1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a favicon
2 participants
@adamkendis @jmensch1