Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Continuous Deployment #691

Merged
merged 6 commits into from
Jun 17, 2020
Merged

Conversation

adamkendis
Copy link
Member

Fixes #656

AWS changes

  • Working URL for dev site: dev.311-data.org
  • New Cloudfront distribution for dev site.
  • Added ALIAS record in Route53 to point dev.311-data.org to new Cloudfront distribution.
  • Added Cloudfront permissions to dev-deploy IAM user so the Cloudfront cache can be invalidated on each dev/prod deploy. I can't imagine we'll ever hit the 1000 free invalidation paths/month limit.
  • Updated dev and prod S3 bucket permissions.

New Secrets

S3_BUCKET_DEV
S3_BUCKET_PROD
CDN_DISTRIBUTION_ID_DEV
CDN_DISTRIBUTION_ID_PROD
SERVER_URL_DEV  ->   EC2 instance

Workflows

  • Removed github-pages deployment from workflows.
  • CI/CD workflows for dev and production.
    • Builds the project and syncs dist directory to corresponding S3 bucket.
    • Creates invalidation for corresponding Cloudfront distribution.

@adamkendis adamkendis requested a review from jmensch1 June 16, 2020 22:07
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I was wondering whether we need to run the tests in these workflows, since we're already running them when there's a pull request. But I guess it doesn't matter since the tests aren't really doing anything right now anyway.

@adamkendis
Copy link
Member Author

Yeah, you're right. Running the tests is pointless in the new workflows. I'll pull it out.

@adamkendis adamkendis merged commit 02f2601 into dev Jun 17, 2020
@adamkendis adamkendis deleted the 656-FRONT-continuousDeployment branch June 17, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate front end deployment to S3
2 participants