Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postman integration #689

Merged
merged 3 commits into from
Jun 16, 2020
Merged

postman integration #689

merged 3 commits into from
Jun 16, 2020

Conversation

jmensch1
Copy link
Contributor

Fixes #684

This integrates Postman tests into our backend CI workflow, so we can make sure all the endpoints are working before a pull request is accepted to dev or master. Here's how it works:

  • install the backend on the CI ubuntu instance using docker-compose
  • populate the db with 500 rows, and run the api
  • run a separate docker container that hits the api with all of the tests in the Postman CI collection
  • stop the build if any of the tests fails

The CI collection includes 15 api calls to test the endpoints. They include both good input and bad input (like missing required params, nonexistent endpoints). The results are reported in on the Actions tab:

postman

The CI tests can also be run locally in Postman itself (the GUI version), and there's a README explaining how to import and run them.

Other things in the PR: (1) a couple of new unit tests (using pytest), (2) added sendgrid to the backend dependencies, which I forgot to do in my last PR.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jmensch1 jmensch1 requested a review from adamkendis June 15, 2020 00:08
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, I never thought of using Postman in CI. Awesome.

@adamkendis adamkendis merged commit 9840965 into dev Jun 16, 2020
@adamkendis adamkendis deleted the 684-BACK-PostmanIntegration branch June 16, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run Postman/Newman tests against the api during continuous integration
2 participants