Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie notice, privacy policy #662

Merged
merged 8 commits into from
May 30, 2020

Conversation

adamkendis
Copy link
Member

Fixes #612

  • Implemented cookie notice - appears on all pages until user clicks the button. Clicking the button adds 'accept-cookies': true to sessionStorage. accept-cookies stays in sessionStorage on page refresh but clears when the browser tab is closed. Since the redux store clears on browser refresh, initial page load and every route change checks sessionStorage for 'accept-cookies' and updates the store if it exists.

  • Added privacy policy page and updated all related links.

  • Added beta tag to header brand logo.

    • Up to date with dev branch
    • Branch name follows guidelines
    • All PR Status checks are successful
    • Peer reviewed and approved

Any questions? See the getting started guide

@adamkendis adamkendis requested a review from jmensch1 May 30, 2020 05:29
@adamkendis adamkendis added this to the 311-Data - Beta milestone May 30, 2020
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real good. I like the way you hooked into the router.

@adamkendis adamkendis merged commit 8a98010 into hackforla:dev May 30, 2020
@johnr54321 johnr54321 added the Role: Frontend React front end work label Jun 2, 2020
@johnr54321
Copy link
Member

@adamkendis Not seeing the privacy policy show up or the cookie notice on prod. Is this on dev yet?

@adamkendis
Copy link
Member Author

@johnr54321 Newest changes haven't been deployed yet. We'll do a release update during tonight's meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Role: Frontend React front end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft Privacy Policy and Cookie Notice
3 participants