Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back small fixes #660

Merged
merged 2 commits into from
May 27, 2020
Merged

Back small fixes #660

merged 2 commits into from
May 27, 2020

Conversation

jmensch1
Copy link
Contributor

@jmensch1 jmensch1 commented May 27, 2020 •
edited by adamkendis
Loading

Two little things: (1) a quick fix for a problem I found when ingesting on heroku regarding a duplicate srnumber, and (2) renaming performanceStatistics to perf

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jmensch1 jmensch1 requested a review from adamkendis May 27, 2020 17:42
@jmensch1 jmensch1 added this to the 311-Data - Beta milestone May 27, 2020
adamkendis
adamkendis approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Pretty sure I hit the duplicate srnumber error yesterday when trying to reseed my local db with all years.

@adamkendis adamkendis merged commit cf23ee8 into dev May 27, 2020
@adamkendis adamkendis deleted the BACK-SmallFixes branch May 27, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkendis adamkendis adamkendis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
311-Data - Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@jmensch1 @adamkendis