picklecache #623
Merged
picklecache #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkendis
reviewed
May 19, 2020
|
hey, great question. I haven’t completely thought it through, but we could
do something like running through the existing cache files whenever a new
one is created, and deleting the ones that haven’t been accessed in a
while. Or maybe run a cron job that does the same thing.
It’s a bit of a tricky problem, so i was gonna see if it worked first
before figuring all that out. If there’s no significant performance boost,
it might not be worth the effort of hammering out those details.
Another problem with the concept is that it doesn’t scale well across
multiple boxes, if we ever need to expand. But i figure we can cross that
bridge later.
…On Mon, May 18, 2020 at 7:22 PM Adam Kendis ***@***.***> wrote:
***@***.**** commented on this pull request.
Any idea how this handles cleanup/expiration of cached data?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#623 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFYMD5SOMFSHMBYPH2YIALRSHUQFANCNFSM4NERPXYA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a drop-in replacement for Redis that caches stuff in the filesystem using python's
picklemodule. The filenames are the same as the keys that we're already using for Redis. So it's essentially a file-based key-value store.On my local, the picklecache is about the same speed as Redis. And it won't be subject to the 25M limit that we have on heroku-redis. So I want to see how it performs on production.
The code here doesn't do anything unless an environment variable called PICKLECACHE is set to 1, in which case it replaces Redis with the picklecache. When this is live I'll toggle the environment variable on heroku and see if there's any improvement.
devbranchAny questions? See the getting started guide