Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605 and #511
This changes some of our endpoints to limit database calls and make the api cleaner. The PR looks like a lot of changes, but it's mostly just reorganizing code that was already there.
Visualizations endpoints
We've been hitting three separate visualizations endpoints every time the user clicks "Submit":
/requestfrequency
,/requestcounts
, and/timetoclose
. This consolidates them into a single/visualizations
endpoint that makes a single request to the database (instead of 3 separate DB calls that ask for a lot of the same data).Comparison endpoints
We still have three comparison endpoints, since the frontend calls them individually. But this puts them in a single ComparisonService, with new signatures for the endpoints:
/comparison/frequency
/comparison/timetoclose
/comparison/counts
There's a small amount of frontend code here to integrate the new endpoints. I also removed the
/pins
endpoint and service since we're not using it any more.dev
branchAny questions? See the getting started guide