Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved lastPulled into /apistatus response #549

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

jmensch1
Copy link
Contributor

@jmensch1 jmensch1 commented Apr 22, 2020

This adds the lastPulled time for the DB to the response from /apistatus, and removes it from the responses from the other endpoints. The frontend consumes the value when the app loads up and immediately displays it in the footer.

This change will make it easier to refactor/optimize our backend services since they won't have to worry about preserving the lastPulled value in all of the responses from the DataService.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jmensch1 jmensch1 requested a review from sellnat77 April 22, 2020 00:39
@sellnat77 sellnat77 merged commit f89c14b into dev Apr 22, 2020
@sellnat77 sellnat77 deleted the LastPulledInApiStatus branch April 22, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants