Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added healthcheck endpoint and fixed environment overrides #540

Merged
merged 2 commits into from
Apr 19, 2020

Conversation

sellnat77
Copy link
Member

@sellnat77 sellnat77 commented Apr 19, 2020

Fixes #359
Fixes #486

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@sellnat77 sellnat77 requested a review from jmensch1 April 19, 2020 20:37
if os.environ.get('PROJECT_URL', None):
app.config['Settings']['Github']['PROJECT_URL'] =\
os.environ.get('PROJECT_URL')
settings = app.config['Settings']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is way better!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was bugging me for so long haha

@sellnat77 sellnat77 merged commit 7601a45 into dev Apr 19, 2020
@sellnat77 sellnat77 deleted the 359_BACK_healthcheck branch April 19, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure how the backend gets config [Service] Healthcheck service
2 participants