Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github integration - issue/project card creation #481

Merged
merged 8 commits into from
Apr 1, 2020

Conversation

adamkendis
Copy link
Member

@adamkendis adamkendis commented Mar 31, 2020

Related to #447

  • Added redacted Github-related vars to server config example file.

  • Implemented FeedbackService for /feedback route. Creates issue via Github API and adds the issue to 311Data-Support project board.

  • Implemented /feedback route. Receives POST containing form data from front-end 'Contact' page.

    • Up to date with dev branch
    • Branch name follows guidelines
    • All PR Status checks are successful
    • Peer reviewed and approved

Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks tight to me. Russell might wanna have a look.

How come the PROJECT_URL is redacted but the ISSUES_URL is not? just curious

@adamkendis
Copy link
Member Author

PROJECT_URL contains a project ID that is only available via an authenticated call to Github's API. I don't think it would expose us because everything would need to be authenticated anyway, but redacted it in an abundance of caution. ISSUES_URL has no specific id.

@sellnat77
Copy link
Member

I'm guessing you'll need me to drop some keys into our secrets right?

@adamkendis
Copy link
Member Author

Yessir. I'll need to get a token from Bonnie. Was just using a personal access token off my account for testing.

@sellnat77
Copy link
Member

We are using a token from my account for some GitHub packaging stuff
Until we have that token I can create another one for the sake of urgency
It's easy to swap the key to a different account

@sellnat77
Copy link
Member

I'll need to review the backend publish step too to make sure those env vars go into the image

@sellnat77 sellnat77 merged commit 6d0e1a6 into hackforla:dev Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants