Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated components to use react router Switch #463

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

brodly
Copy link
Member

@brodly brodly commented Mar 25, 2020

Small refactor to use Switch from react router

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@brodly brodly requested review from jmensch1 and adamkendis March 25, 2020 17:09
@@ -83,7 +53,20 @@ const Menu = ({
/>

<div className="menu-content">
{renderMenu()}
<Switch>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great

Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice man, so clear and simple

Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@adamkendis adamkendis merged commit 9c662d6 into dev Mar 25, 2020
@adamkendis adamkendis deleted the update_react_router branch March 25, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants