Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

332, 412 Map - custom markers, pin popup data fetching, clustering tweak #457

Merged
merged 16 commits into from
Mar 24, 2020

Conversation

adamkendis
Copy link
Member

@adamkendis adamkendis commented Mar 24, 2020

Fixes #332
Fixes #412

  • Map pin fetches data for its srnumber on click.
  • Pin popup displays spinning loader while fetching.
  • Pin popup displays requesttype, ncname, address, createddate, and closeddate OR updateddate and status on successful fetch. Note: city name is not provided by the city in request info. I think we would need an external API (with costs) to match city name to zip or lat/lng, or handle this on the backend if city name is required.
  • DataRequestError modal is displayed if unsuccessful fetch.
  • CustomMarker which replaces default leaflet markers with fontawesome map-marker-alt icon in our Icon component.
  • Custom markers are color-coded to match request type colors in menu (and REQUEST_TYPES constants).
  • Added 'fullType' property to some requests in REQUEST_TYPES constant. We shortened the 'type' of some requests for display purposes ('Graffiti Removal' -> 'Graffiti', 'Electronic Waste' -> 'E-Waste', etc.)

Loading popup:

Screen Shot 2020-03-24 at 12 11 55 PM

Closed request:

Screen Shot 2020-03-24 at 12 11 40 PM

Open/pending request:

Screen Shot 2020-03-24 at 12 10 50 PM

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

@adamkendis adamkendis requested review from brodly and jmensch1 March 24, 2020 19:42
@brodly brodly merged commit b02fb17 into hackforla:dev Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map - color code pins Individual pin to request request info on click
2 participants