-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Frequency Module #432
Conversation
…uest count bar graph; reverted connection string to postgres
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there was a bad merge
Might want to reset files that you didn't intend on changing
Yea, I fixed the bad merge issues in app.py. Is the Terraform failed check something I can work on? Also, something in my code broke regarding data types despite that I didn't change anything in the module; the json response is not going through... gotta fix that EDIT: fixed the merge issues and json response issue, pushing again @sellnat77 : I think it should be OK to merge now |
I'm guessing the terrain issues are failing because you're using a forked repo, your repo doesn't have the required credentials to perform the terrain plan |
} for request in requestTypes] | ||
}] | ||
|
||
# Following is deprecated, saving for reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove all this commented stuff
If we need to reference it we can go through git-history. Otherwise this will make the code messy
@@ -0,0 +1,68 @@ | |||
from configparser import ConfigParser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this file could be defunkt, but we can keep it for now. Lets drop in a comment with the link to the GH issue regarding the precaching
I have a feeling this will become necessary when we start hitting massive scale
@compress.compress() | ||
async def requestfrequency(request): | ||
freq_worker = frequency(app.config['Settings']) | ||
freq_worker = FrequencyService(app.config['Settings']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now this is using hardcoded values, let throw in the logic to pull parameters from the request object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this to unblock others, buts lets create some tech debt tickets to make sure we clean things up later on
Updated frequency module to return data in desired format
Known issues: