Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ingest issues #384

Merged
merged 1 commit into from
Mar 6, 2020
Merged

fixed ingest issues #384

merged 1 commit into from
Mar 6, 2020

Conversation

jmensch1
Copy link
Contributor

@jmensch1 jmensch1 commented Mar 6, 2020

when I ran the /ingest endpoint locally with small limits, I hit some fatal errors because some columns were null for certain date periods. So I put some checks in to handle that. Also had to increase the character limit for the 'ncname' column to handle this guy: UNITED NEIGHBORHOODS OF THE HISTORIC ARLINGTON HEIGHTS, WEST ADAMS, AND JEFFERSON PARK COMMUNITY

@jmensch1 jmensch1 requested a review from sellnat77 March 6, 2020 21:39
@sellnat77
Copy link
Member

Yeah, when we tested out MySQL it enforced char limits for items but with postgres we can exclude the limits
If anything we might want to consider removing the limits altogether
We can discuss on Tuesday @ryanmswan

@jmensch1 jmensch1 merged commit a5980b3 into dev Mar 6, 2020
@jmensch1 jmensch1 deleted the BACKEND-IngestIssues branch March 6, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants