Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#153 Create bare containers to establish general layout #224

Merged
merged 8 commits into from
Feb 5, 2020

Conversation

brodly
Copy link
Member

@brodly brodly commented Feb 1, 2020

#153 Issue

  • Removed unneeded/unused components
  • Reorganized folders based on visual application layout
  • Started color palette file (src/styles/COLORS.js)
  • Restyled layout to follow UI teams mockup

@brodly brodly added the Role: Frontend React front end work label Feb 1, 2020
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments re inline styles and let me know your thoughts. Everything else looks good to me.

</button>
</div>
)}
styles={{ sidebar: { background: 'white' } }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on stripping out the inline style and incorporating into Bulma styles so all styles are centralized? I can get the basic SASS stuff set up this week so we can start matching styles to the mockups.

Alternatively, it might be worthwhile to leave as-is until MVP is achieved.

https://bulma.io/documentation/customize/with-node-sass/

src/components/main/footer/Footer.jsx Show resolved Hide resolved
@adamkendis adamkendis merged commit e56ba94 into dev Feb 5, 2020
@adamkendis adamkendis deleted the restructure_application branch February 5, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Role: Frontend React front end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants