Bugfix closing the datepicker should cancel the ongoing selection 1836 #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the-ongoing-selection-1836
kdow
reviewed
Nov 20, 2024
| // Reassign the From and To Day | ||
|
|
||
| //If both startDate and endDate were already selected. Start a new range selection. | ||
| if(startDate && endDate){ |
There was a problem hiding this comment.
nit: add space after if (lines 175 and 180)
| setFromDay(day); | ||
| updateEndDate(null); | ||
| setEnteredTo(null); | ||
| //If startDate is selected and endDate is unselected, complete the range selection. |
There was a problem hiding this comment.
nit: for comments, add space between // and start of comment
efrenmarin45
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Reviewed the changes and it does resolve the issue brought by #1836
LGTM
DrAcula27
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
@DorianDeptuch Great job on this issue! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct files were edited
- No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
- I agree with the nitpicks from Kelly, if anything else needs changing.
Approved! 👍
ryanfchase
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
@DorianDeptuch feel free to make the "nit" adjustments, otherwise this is looking good 👍
ryanfchase
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1836
mainbranchAny questions? See the getting started guide