-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating master with latest dev #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed build issues
… JSON objects for view_dates function
Finished up all copy for onboarding Updated onboarding docs/script/docker files Added WIP front end docker file Added engineering getting started callout Removed git-lfs check and instructions for existing installations Finished up all copy for onboarding Updated onboarding docs/script/docker files Added WIP front end docker file
Onboarding script/documentation/docker fixes
Fixed webpack side of dockerfile for front end
Adjusted environments and scripts to clean up onboarding
I dont have superior access to merge this until someone has approved........can someone pleaseeeeee approve this? 😅 |
ryanmswan
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to review this from mobile and it was being stubborn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update the front end with the eslint and docker fixes
Onboarding docs and scripts
time to close endpoiont fleshed out