Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bookmark poc #1482

Merged
merged 10 commits into from
Mar 30, 2023
Merged

bookmark poc #1482

merged 10 commits into from
Mar 30, 2023

Conversation

bryantran04
Copy link
Member

Fixes #{issue number here}

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

edwinjue
edwinjue suggested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@edwinjue edwinjue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bryan, this is a very nice and elegant solution! Just a few small requests to rename a few items and remove some unused code. Excellent work.

client/components/main/Desktop/ShareableLinkCreator.jsx Outdated Show resolved Hide resolved
client/components/main/Desktop/ShareableLinkCreator.jsx Outdated Show resolved Hide resolved
client/components/main/Desktop/ShareableLinkCreator.jsx Outdated Show resolved Hide resolved
client/components/Map/index.js Outdated Show resolved Hide resolved
client/components/Map/index.js Outdated Show resolved Hide resolved
client/components/Map/index.js Outdated Show resolved Hide resolved
client/components/Map/Map.jsx Outdated Show resolved Hide resolved
@edwinjue edwinjue self-requested a review March 30, 2023 05:02
@edwinjue edwinjue self-requested a review March 30, 2023 05:08
edwinjue
edwinjue approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@edwinjue edwinjue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround.

If you are unable to merge, you may need to update propTypes for requestTypes in ShareableLinkCreator.propTypes as per latest comment.

Otherwise, feel free to merge

@bryantran04 bryantran04 merged commit 09c8f23 into dev Mar 30, 2023
@bryantran04 bryantran04 deleted the bookmark-link branch March 30, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinjue edwinjue edwinjue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantran04 @edwinjue