Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4 v2 About page #1390

Merged
merged 1 commit into from
Oct 7, 2022
Merged

#4 v2 About page #1390

merged 1 commit into from
Oct 7, 2022

Conversation

edwinjue
Copy link
Member

@edwinjue edwinjue commented Oct 6, 2022

Contributes to #1347

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@edwinjue edwinjue requested review from funbunch, nichhk and jekijo October 6, 2022 01:50
@funbunch
Copy link
Member

funbunch commented Oct 6, 2022

Looks like a lot of work. Love that you streamlined our styles. Can we also get a screenshot here? I have a question on the Textheading. The "311 Data" was different colors before and I can't see, but looks like it'd be all one now. Unless this has changed.

@edwinjue
Copy link
Member Author

edwinjue commented Oct 6, 2022

@funbunch thanks Shannon!

yes, it appears the v2 design is now a standard heading with blue background. you will need to scroll down to the bottom of the figma to find them. I've included a screenshot of the area on that document for reference

image

@edwinjue edwinjue mentioned this pull request Oct 6, 2022
Closed
11 tasks
@funbunch
Copy link
Member

funbunch commented Oct 7, 2022

Thanks for the update. Looks better! Will approve.

@edwinjue edwinjue merged commit 02c007e into dev Oct 7, 2022
@edwinjue edwinjue deleted the 1347-thematic-coloring-of-content-pages-4-v2-about branch October 7, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funbunch funbunch funbunch approved these changes

@nichhk nichhk Awaiting requested review from nichhk

@jekijo jekijo Awaiting requested review from jekijo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwinjue @funbunch