Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 v2 new components #1388

Merged

Conversation

edwinjue
Copy link
Member

@edwinjue edwinjue commented Oct 4, 2022

Contributes to #1347

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

…dark theme, while all other pages utilize the light theme. also added a few new components that will be used by all v2 content pages
@edwinjue edwinjue requested review from nichhk and jekijo October 4, 2022 06:09
@edwinjue edwinjue mentioned this pull request Oct 4, 2022
11 tasks
@edwinjue
Copy link
Member Author

edwinjue commented Oct 4, 2022

@jekijo Killen, another one for you. If you have any questions, feel free to let me know. Thanks!

Copy link
Member

@jekijo jekijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge when ready 👍

@edwinjue edwinjue merged commit e3b7eaa into dev Oct 4, 2022
@edwinjue edwinjue deleted the 1347-thematic-coloring-of-content-pages-2-v2-new-components branch October 4, 2022 22:34
@edwinjue
Copy link
Member Author

edwinjue commented Oct 4, 2022

@jekijo Thanks Killen! Will probably send out the third one later tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants