-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: Contact form submit button does not show up when screen resolution height <= 690px #1341
Fixes: Contact form submit button does not show up when screen resolution height <= 690px #1341
Conversation
…lent to the footer to compensate for a fixed positioned footer that blocks visibility of portions of the contact form, namely submit button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer changing the positioning of the footer, since this is an issue that could affect all of our pages (not just contact). Wdyt?
Thanks for the feedback Nich. Sure, that works for me as long as you are okay with Additionally, it currently seems the other pages may be utilizing some bottom padding to mitigate the issue: 311-data/client/components/main/About.jsx Line 35 in c0a2caf
|
…iner from the bottom of the contact form (to compensate for a fixed positioned footer that blocks visibility of the submit button). instead, changed footer position: fixed to position: sticky
ok, in the latest PR, I restored my original contact form design and updated position in the footer component from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One small comment.
Re: other pages compensating for the old fixed
behavior: can you open an issue to investigate and fix those instances?
Re: browser compatibility: yeah, I took a look, and I don't think we need to worry about those :)
client/components/contact/__tests__/__snapshots__/contactForm.test.js.snap
Outdated
Show resolved
Hide resolved
…Form.test.js.snap per review notes
Added a grid container to bottom of contact form with a height equivalent to the footer to compensate for a fixed positioned footer that blocks visibility of portions of the contact form, namely
submit button
. Submit button now appears when scrolling all the way down to bottom when there is not enough screen real-estate as per attached screenshot (compare with attachment in #1340)Alternative fixes:
Change
position: 'fixed'
toposition: 'sticky'
in Footer as per stackoverflow (see which browsers support position: 'sticky')Fixes #1340
dev
branchAny questions? See the getting started guide