Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Contact form submit button does not show up when screen resolution height <= 690px #1341

Conversation

edwinjue
Copy link
Member

@edwinjue edwinjue commented Sep 7, 2022

Added a grid container to bottom of contact form with a height equivalent to the footer to compensate for a fixed positioned footer that blocks visibility of portions of the contact form, namely submit button. Submit button now appears when scrolling all the way down to bottom when there is not enough screen real-estate as per attached screenshot (compare with attachment in #1340)

Alternative fixes:
Change position: 'fixed' to position: 'sticky' in Footer as per stackoverflow (see which browsers support position: 'sticky')

Fixes #1340

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

2022-09-06 21_56_17-

Any questions? See the getting started guide

…lent to the footer to compensate for a fixed positioned footer that blocks visibility of portions of the contact form, namely submit button
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer changing the positioning of the footer, since this is an issue that could affect all of our pages (not just contact). Wdyt?

@edwinjue
Copy link
Member Author

edwinjue commented Sep 8, 2022

Thanks for the feedback Nich. Sure, that works for me as long as you are okay with position: sticky not being available on older browsers. Although we use MUI, we should keep in mind there are still a few older browsers where position: sticky isn't available where mui is still supported.

Additionally, it currently seems the other pages may be utilizing some bottom padding to mitigate the issue:

paddingBottom: '6em',

…iner from the bottom of the contact form (to compensate for a fixed positioned footer that blocks visibility of the submit button). instead, changed footer position: fixed to position: sticky
@edwinjue edwinjue requested a review from nichhk September 8, 2022 01:50
@edwinjue
Copy link
Member Author

edwinjue commented Sep 8, 2022

ok, in the latest PR, I restored my original contact form design and updated position in the footer component from position: fixed to position: sticky. I confirmed the document will scroll down to the submit button when screen resolution height <= 690px. the only other pages I was able to verify are loading as expected after this change are Map and About page. the other pages on my local copy (FAQ, Blog, Privacy) seem to want to load content from contentful which I do not have an API key for

Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small comment.

Re: other pages compensating for the old fixed behavior: can you open an issue to investigate and fix those instances?

Re: browser compatibility: yeah, I took a look, and I don't think we need to worry about those :)

@edwinjue edwinjue requested a review from nichhk September 8, 2022 03:36
@edwinjue edwinjue merged commit ad3d29d into dev Sep 8, 2022
@edwinjue edwinjue deleted the 1340-contact-form-submit-button-does-not-show-up-when-screen-resolution-height-=-690px branch September 8, 2022 03:40
@edwinjue edwinjue restored the 1340-contact-form-submit-button-does-not-show-up-when-screen-resolution-height-=-690px branch September 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact form submit button does not show up when screen resolution height <= 690px
2 participants