Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed syntax error in Run unit tests #1329

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Conversation

edwinjue
Copy link
Member

Fixes #1328

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@edwinjue edwinjue requested review from nichhk and mattyweb August 24, 2022 02:45
@edwinjue edwinjue linked an issue Aug 24, 2022 that may be closed by this pull request
1 task
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edwin! To test this, you can either make a no-op change in server/, or I think you can add a workflow_dispatch line, which allows you to manually trigger a run from the Github Actions page. I'm not sure if the latter will work the first time around (i.e., when the change is committed to a feature branch), but please try it out.

@edwinjue edwinjue merged commit 70261df into dev Aug 24, 2022
@edwinjue edwinjue deleted the 1328-build-and-test-540-failed branch August 24, 2022 16:45
@edwinjue
Copy link
Member Author

i will give it a try later today, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and Test #540 (Failed)
2 participants