Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data source documentation #1285

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Update data source documentation #1285

merged 3 commits into from
Jul 22, 2022

Conversation

joshuayhwu
Copy link
Contributor

@joshuayhwu joshuayhwu commented Jul 21, 2022 •
edited
Loading

Fixes #{issue number here}

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

nichhk
nichhk approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh! This is super helpful. Two small comments. Please merge it after fixing them.

misc/DataSources.md Show resolved Hide resolved
misc/DataSources.md Outdated Show resolved Hide resolved
@joshuayhwu joshuayhwu merged commit 10d3ecb into dev Jul 22, 2022
@joshuayhwu joshuayhwu deleted the UpdateDocumentation branch July 22, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichhk nichhk nichhk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuayhwu @nichhk