Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1253 request type selector not working #1263

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented Jun 29, 2022

Fixes #1253

Most of the changed lines are just the autoformatter doing work.

The actual code changes:

  1. Make RequestsLayer a connected component such that its prop selectedTypes is synchronized with the redux state.filter.requestTypes.
  2. Fix the typeFilter to operate on an array of typeIds, which is what the MapBox GL API expects.

Here we can see the map with only "Electronic Waste" selected:
ewaste-only

And here's the map with all types selected:
all-types

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk requested a review from ardada2468 June 29, 2022 21:07
Copy link
Contributor

@ardada2468 ardada2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should work.

@ardada2468 ardada2468 merged commit 6e2c070 into dev Jun 30, 2022
@ardada2468 ardada2468 deleted the 1253-request-type-selector-not-working branch June 30, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Type Selector not working
2 participants