Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub/SendGrid config info to .env file for create_release_dev.yml, partially fixing #1099 #1206

Merged
merged 2 commits into from
May 26, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented May 25, 2022

Partially fixes #1099

This makes the happy path work successfully on my local environment: upon feedback submission, the server will create a new GH issue, add it to the GH project, and send an email to the user using SendGrid.

This does NOT address another issue: if any of these steps fail, the "Submit" button will still be spinning.

contact-v1-sendgrid

Upon submission, we will need to manually trigger this workflow (which is why I added the workflow_dispatch). Then, I believe we will need to update the ecs service for prod (this workflow only updates the dev service), but I can do that in the AWS CLI.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk requested a review from joshuayhwu May 25, 2022 21:15
Copy link
Contributor

@joshuayhwu joshuayhwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@nichhk
Copy link
Member Author

nichhk commented May 26, 2022

Thanks for the review Josh!

@nichhk nichhk merged commit f978fa9 into dev May 26, 2022
@nichhk nichhk deleted the 1099-v1-contact-us-form-not-working-on-live-site-dev branch May 26, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 - Contact Us form not working on live site
2 participants