Added zindex to datepicker and footer #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkendis
reviewed
Nov 12, 2021
| @@ -15,6 +15,7 @@ const Styles = ({ range }) => { | |||
| background: ${theme.palette.primary.dark}; | |||
| border-radius: 5px; | |||
| min-width: 268px; | |||
| z-index: 5000; | |||
There was a problem hiding this comment.
After adding zIndex: 1 to DatePicker.jsx selectorPopUp, is z-index still needed here?
There was a problem hiding this comment.
+1
I would also recommend using a value that is more consistent with the others, as opposed to an arbitrary large number like 5000 as it will make it easier to manage all the other z-indexes in the future.
There was a problem hiding this comment.
Just updated Styles.jsx.
adamkendis
reviewed
Nov 12, 2021
|
@roz0n It looks like Shannon has made an update. Can you provide a PR on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140
devbranchAny questions? See the getting started guide