Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce frontend linting from GitHub action #235

Closed
3 tasks done
sellnat77 opened this issue Feb 8, 2020 · 1 comment
Closed
3 tasks done

Enforce frontend linting from GitHub action #235

sellnat77 opened this issue Feb 8, 2020 · 1 comment
Assignees
@sellnat77
Labels
Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) Enhancement New feature or request Role: Frontend React front end work size: Missing v1 The first version of the site Workflows Setup/Maintenance of Github actions
Milestone
311 Data Alpha - ...

Comments

@sellnat77
Copy link
Member

sellnat77 commented Feb 8, 2020 •
edited
Loading

Overview

This will add restrictions to frontend pull requests to ensure consistency across the codebase

Action Items

  • include a lint step in the frontend CI GitHub action process
    • lint step should just use npm run lint
  • test with a PR and make sure it gets rejected if the frontend code fails linting
@sellnat77 sellnat77 added Enhancement New feature or request Role: Frontend React front end work Workflows Setup/Maintenance of Github actions labels Feb 8, 2020
@sellnat77
Copy link
Member Author

sellnat77 commented Feb 9, 2020 •
edited
Loading

@brodly Im gonna get linting enforcement in
Any complaints against using airbnb's styleguide?
Just saw you already have that configured haha

@sellnat77 sellnat77 self-assigned this Feb 9, 2020
sellnat77 added a commit that referenced this issue Feb 9, 2020
@sellnat77
Fixes #235 Enforced a frontend linting step to protect PRs
bccecf6
sellnat77 added a commit that referenced this issue Feb 9, 2020
@sellnat77
Fixes #235 Enforced a frontend linting step to protect PRs
a65f5fd
sellnat77 added a commit that referenced this issue Feb 10, 2020
@sellnat77
Fixes #235 Enforced a frontend linting step to protect PRs
a76760c 
Actually running linting

Addressed all linting errors

Removed unused test
@sellnat77 sellnat77 mentioned this issue Feb 10, 2020
Merged
sellnat77 added a commit that referenced this issue Feb 12, 2020
@sellnat77
Merge pull request #241 from hackforla/235_FE_linting
323d07e 
Fixes #235 Enforced a frontend linting step to protect PRs
@github-project-automation github-project-automation bot moved this to Done (without merge) in P: 311: Project Board Aug 22, 2024
@Rabia2219 Rabia2219 added the v1 The first version of the site label Aug 22, 2024
@cottonchristopher cottonchristopher added the Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sellnat77 sellnat77

Labels
Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) Enhancement New feature or request Role: Frontend React front end work size: Missing v1 The first version of the site Workflows Setup/Maintenance of Github actions
Projects
P: 311: Project Board
Status: Done (without merge)
Milestone
311 Data Alpha - Dev Complete
Development

No branches or pull requests
4 participants
@sellnat77 @ExperimentsInHonesty @Rabia2219 @cottonchristopher