-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map should display a loading modal when it's retrieving new data #1284
Comments
@elizabeth-ux and @melissahermes99, could you design a loading indicator for the map? On the eng side, I've gotten a material-ui CircularProgress component to load, but it doesn't look good. |
I've come up with two test loading indicators for the map. The first indicator utilizes the logo and the second is just a simple loading bar. If neither of these is what we're looking for I can keep experimenting to find something that works. For now, you can find the UI for both indicators under the Map Loading Screen Test page. I've gone ahead and created a quick prototype for both indicators as well. |
Thanks Melissa! They look great. I prefer the first one, but would appreciate feedback from others! @elizabeth-ux @EchoProject any thoughts? |
I also like the first. @melissahermes99 Is it possible to have the shimmer go in the other direction (from left to right)? @nichhk The darkened state of the page while loading isn't currently a feature, correct? Are we building this in? I think it'll look weird if the screen isn't darkened given the colors. |
I've updated the first loading indicator to move to the left. |
I have created a progress bar. I am not sure if looping it is a good idea, so I've slowed down the speed of it's progression. You can view it here. |
Thanks Melissa, this looks good to me! Was there any discussion last night about which loading indicator to go with? |
I think we landed with the bar at the top, below the nav, would prompt as orange and then turn teal during the loading. The color change would not loop, and the background would not darken. @melissahermes99 am I missing anything? |
Sounds good! I did have to make a slight adjustment to the canvas to lower to bar just a bit. I had previously had it overlapping the header on accident. I've updated the color transitions as well to make the flow of the loading bar more smooth. |
Hey @jekijo Do you have an update for us on this issue? Please update:
Thanks! |
Overview
Currently, it can take up to 25s for the dev site to pull data for the past month. We should display a loading modal in these situations.
Action Items
Resources
The text was updated successfully, but these errors were encountered: