Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map should display a loading modal when it's retrieving new data #1284

Closed
2 tasks
Tracked by #1380
nichhk opened this issue Jul 14, 2022 · 12 comments · Fixed by #1304
Closed
2 tasks
Tracked by #1380

Map should display a loading modal when it's retrieving new data #1284

nichhk opened this issue Jul 14, 2022 · 12 comments · Fixed by #1304
Assignees
Labels
Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) P-feature: Map Role: Frontend React front end work size: 8pt Can be done in 31-48 hours
Milestone

Comments

@nichhk
Copy link
Member

nichhk commented Jul 14, 2022

Overview

Currently, it can take up to 25s for the dev site to pull data for the past month. We should display a loading modal in these situations.

Action Items

  • Design a loading indicator.
  • Display it when the client is retrieving data, and hide it when the client finishes retrieving data

Resources

@EchoProject EchoProject added Role: Frontend React front end work size: 8pt Can be done in 31-48 hours P-feature: Map labels Jul 15, 2022
@EchoProject EchoProject added this to the v2.1 Launch milestone Jul 15, 2022
@nichhk nichhk self-assigned this Jul 20, 2022
@nichhk
Copy link
Member Author

nichhk commented Aug 1, 2022

@elizabeth-ux and @melissahermes99, could you design a loading indicator for the map?

On the eng side, I've gotten a material-ui CircularProgress component to load, but it doesn't look good.

bad-loading-modal

@nichhk nichhk linked a pull request Aug 1, 2022 that will close this issue
4 tasks
@nichhk nichhk reopened this Aug 2, 2022
@melissahermes99
Copy link
Member

I've come up with two test loading indicators for the map. The first indicator utilizes the logo and the second is just a simple loading bar. If neither of these is what we're looking for I can keep experimenting to find something that works. For now, you can find the UI for both indicators under the Map Loading Screen Test page.

I've gone ahead and created a quick prototype for both indicators as well.
https://www.figma.com/proto/eF63O8yIGz2soQ4JJFfyoK/311_Data_UXUI?node-id=5106%3A17198&scaling=contain&page-id=2375%3A0&starting-point-node-id=5106%3A17185&show-proto-sidebar=1

image
image

@nichhk
Copy link
Member Author

nichhk commented Aug 4, 2022

Thanks Melissa! They look great. I prefer the first one, but would appreciate feedback from others! @elizabeth-ux @EchoProject any thoughts?

@EchoProject
Copy link
Contributor

I also like the first. @melissahermes99 Is it possible to have the shimmer go in the other direction (from left to right)?

@nichhk The darkened state of the page while loading isn't currently a feature, correct? Are we building this in?
So every time the screen is loading it darkens? Makes sense for predictably long loads, but I feel like it'll be eye straining if the load happens quickly and possible more than once.

I think it'll look weird if the screen isn't darkened given the colors.

@melissahermes99
Copy link
Member

I also like the first. @melissahermes99 Is it possible to have the shimmer go in the other direction (from left to right)?

I've updated the first loading indicator to move to the left.
image

@nichhk nichhk reopened this Aug 5, 2022
@melissahermes99
Copy link
Member

I have created a progress bar. I am not sure if looping it is a good idea, so I've slowed down the speed of it's progression. You can view it here.

image

@nichhk
Copy link
Member Author

nichhk commented Aug 12, 2022

Thanks Melissa, this looks good to me! Was there any discussion last night about which loading indicator to go with?

@nichhk nichhk removed their assignment Aug 12, 2022
@EchoProject
Copy link
Contributor

I think we landed with the bar at the top, below the nav, would prompt as orange and then turn teal during the loading. The color change would not loop, and the background would not darken. @melissahermes99 am I missing anything?

@melissahermes99
Copy link
Member

Sounds good! I did have to make a slight adjustment to the canvas to lower to bar just a bit. I had previously had it overlapping the header on accident. I've updated the color transitions as well to make the flow of the loading bar more smooth.

@nichhk
Copy link
Member Author

nichhk commented Sep 13, 2022

Update for Killen: we already have an ugly loading indicator on the dev site, but we want to upgrade it to the one that Melissa designed. You can see how I added the ugly loading indicator here.

@EchoProject EchoProject removed this from the v2.1 Launch milestone Dec 8, 2022
@mc759
Copy link
Member

mc759 commented Dec 13, 2022

Hey @jekijo Do you have an update for us on this issue?

Please update:

  • Progress:
  • Blockers:
  • Availability:
  • ETA:

Thanks!

@jekijo
Copy link
Member

jekijo commented Dec 14, 2022

Hey @mc759, I actually finished this issue a while ago and submitted a pull request (#1412 ). I didn't know the issue hadn't been closed yet, but I'll go ahead and do that now

@jekijo jekijo closed this as completed Dec 14, 2022
@mc759 mc759 added this to the H123 Map Page milestone Jan 26, 2023
@ExperimentsInHonesty ExperimentsInHonesty moved this to Done (without merge) in P: 311: Project Board Jun 7, 2024
@cottonchristopher cottonchristopher added the Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) P-feature: Map Role: Frontend React front end work size: 8pt Can be done in 31-48 hours
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

7 participants